fix(cli): abort OKF export on incomplete file scans

Signed-off-by: phernandez <paul@basicmachines.co>

Author: phernandez

src/basic_memory/index/local_project.py

@@ -4,6 +4,7 @@
 
 import asyncio
 import os
+import stat
 from collections.abc import Mapping, Sequence
 from contextlib import nullcontext
 from dataclasses import dataclass
@@ -223,6 +224,7 @@ def scan_local_project_index_files(
     project_root: Path,
     *,
     ignore_patterns: LocalProjectIndexIgnorePatterns | None = None,
+    strict: bool = False,
 ) -> LocalProjectIndexScan:
     """Walk one local project and report eligible files plus unreadable subtrees."""
     project_root = project_root.expanduser().resolve()
@@ -254,7 +256,7 @@ def _scan_error(error: OSError) -> None:
             # The root scan failed (onerror re-raised). Never return an empty,
             # delete-everything snapshot; files discovered before a deeper traversal
             # error are kept.
-            if not file_paths:
+            if strict or not file_paths:
                 raise
             break
 
@@ -269,16 +271,23 @@ def _scan_error(error: OSError) -> None:
 
         for name in filenames:
             path = root_path / name
-            try:
-                if path.is_symlink() or not path.is_file():
-                    continue
-            except OSError:
-                continue
             relative_path = path.relative_to(project_root).as_posix()
             if local_relative_path_is_filtered(relative_path):
                 continue
             if should_ignore_path(path, project_root, active_ignore_patterns):
                 continue
+            try:
+                # Export requires every eligible file: lstat propagates errors that
+                # pathlib predicates may suppress, without following symlinks.
+                if strict:
+                    if not stat.S_ISREG(path.lstat().st_mode):
+                        continue
+                elif path.is_symlink() or not path.is_file():
+                    continue
+            except OSError:
+                if strict:
+                    raise
+                continue
             file_paths.append(relative_path)
 
     return LocalProjectIndexScan(

src/basic_memory/okf/export.py

@@ -82,7 +82,7 @@ def snapshot_files(root: Path) -> tuple[ExportFile, ...]:
     from basic_memory.index.local_wiki_projection import _is_projector_owned
     from basic_memory.runtime.storage import runtime_file_path_is_markdown_note
 
-    scan = scan_local_project_index_files(root)
+    scan = scan_local_project_index_files(root, strict=True)
     if scan.unreadable_directories:
         raise OSError("Incomplete project scan: " + ", ".join(scan.unreadable_directories))
     files = []

tests/index/test_local_project_scan_parity.py

@@ -159,7 +159,8 @@ def test_local_project_index_file_paths_aborts_when_root_unreadable(tmp_path: Pa
         local_project_index_file_paths(missing_root, ignore_patterns=set())
 
 
-def test_local_project_index_file_paths_skips_symlinked_files(tmp_path: Path) -> None:
+@pytest.mark.parametrize("strict", [False, True])
+def test_local_project_index_file_paths_skips_symlinked_files(tmp_path: Path, strict: bool) -> None:
     """Symlinked files must not be indexed (their target may be outside the project)."""
     project_root = (tmp_path / "project").resolve()
     project_root.mkdir()
@@ -171,7 +172,21 @@ def test_local_project_index_file_paths_skips_symlinked_files(tmp_path: Path) ->
     except (OSError, NotImplementedError):
         pytest.skip("symlinks not supported on this platform")
 
-    assert local_project_index_file_paths(project_root, ignore_patterns=set()) == ("keep.md",)
+    assert scan_local_project_index_files(
+        project_root, ignore_patterns=set(), strict=strict
+    ).file_paths == ("keep.md",)
+
+
+def test_strict_scan_rejects_partial_walk(tmp_path: Path, monkeypatch) -> None:
+    (tmp_path / "a.md").write_text("# A", encoding="utf-8")
+
+    def partial_walk(*args, **kwargs):
+        yield str(tmp_path), [], ["a.md"]
+        raise PermissionError("walk failed after a file")
+
+    monkeypatch.setattr(local_project.os, "walk", partial_walk)
+    with pytest.raises(PermissionError, match="walk failed after a file"):
+        scan_local_project_index_files(tmp_path, ignore_patterns=set(), strict=True)
 
 
 @pytest.mark.asyncio

tests/okf/test_export_failures.py

@@ -279,3 +279,25 @@ def test_reserved_directory_is_rejected_before_staging(source_config, directory)
     (parent / "a.md").write_text("---\ntype: note\n---\n# A")
     with pytest.raises(ValueError, match="reserved OKF directory name; rename it first"):
         snapshot_files(root)
+
+
+@pytest.mark.asyncio
+async def test_file_stat_failure_preserves_replacement_destination(
+    source_config, tmp_path, monkeypatch
+):
+    root = Path(source_config.projects["export"].path)
+    source = root / "a.md"
+    destination = tmp_path / "bundle"
+    destination.mkdir()
+    (destination / "keep").write_bytes(b"previous bundle")
+    original_lstat = Path.lstat
+
+    def failing_lstat(path, *args, **kwargs):
+        if path == source:
+            raise PermissionError(13, "stat unavailable", str(path))
+        return original_lstat(path, *args, **kwargs)
+
+    monkeypatch.setattr(Path, "lstat", failing_lstat)
+    with pytest.raises(PermissionError, match="stat unavailable"):
+        await export_project(source_config, "export", destination, replace=True)
+    assert (destination / "keep").read_bytes() == b"previous bundle"