Links to issues from the docs page don't work.

[jdalegonzalez]

This might not be the proper repo to put this issue in but since the bug is about a missing repo... ::shrug::

The baseten documentation has links to create issues for the documentation that look like....

https://github.com/basetenlabs/docs.baseten.co/issues/new?title=Issue%20on%20docs&body=Path:%20/truss/examples/02-llm

However, the docs.baseten.co repo is apparently not public or not setup yet and as a result, these links 404.

( And... there are some issues with the docs but I have no place to post them yet. :D )

[squidarth]

Hi @jdalegonzalez, thanks for reporting. The docs repo is not public, we'll remove those links.

And would love to hear any feedback you have on the docs -- thank you! (Feel free to post back here)

[jdalegonzalez]

The docs page: https://docs.baseten.co/truss/examples/02-llm includes the code snippet

        prompt = request.pop("prompt")
        generate_args = {
            "max_new_tokens": request.get("max_new_tokens", 128),
            "temperature": request.get("temperature", 1.0),
            "top_p": request.get("top_p", 0.95),
            "top_k": request.get("top_p", 50),
            "repetition_penalty": 1.0,
            "no_repeat_ngram_size": 0,
            "use_cache": True,
            "do_sample": True,
            "eos_token_id": self.tokenizer.eos_token_id,
            "pad_token_id": self.tokenizer.pad_token_id,
        }

I suspect that's a typo - not working code. Notice that "top_k" is being set the to value of "top_p" from the args. If top_k is supposed to come from top_p, it would be nice to have a comment explaining why.

[jdalegonzalez]

For what it's worth, I've noticed a couple of other doc issues, miss-typings mostly. I'm happy to report them but none are serious.

[squidarth]

Great, thank you!