Fix dom_id delegation for Rails 8.2 compatibility #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using Lexxy 0.1.23.beta with Rails 8.2.0.alpha, the
lexxy_rich_text_areahelper raises:This happens because when
Lexxy::ActionTextTagis prepended toActionView::Helpers::Tags::ActionText, thedom_idmethod (which Rails delegates toActionView::RecordIdentifier) isn't accessible from within the prepended module's methods.Fix
Add an explicit delegation using
ActiveSupport::Concern'sprependedblock, which runs when the module is prepended and sets up the delegation on the target class.Test plan
form_test.rbexercise the form helper which usesdom_id