Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open FPL logo on side bar got reanimated every time route changed #9

Open
bapairaew opened this issue Jul 19, 2021 · 1 comment
Open

Open FPL logo on side bar got reanimated every time route changed #9

bapairaew opened this issue Jul 19, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@bapairaew
Copy link
Owner

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://openfpl.com/players
  2. Click on either Fixtures and Team Planner link on the side bar

Expected behavior
Open FPL logo stays still
@bapairaew bapairaew added the bug Something isn't working label Jul 19, 2021
@bapairaew
Copy link
Owner Author

Tried pulling out the logo component and wrapping it with memo(() => <RoughNotation ... />, () => true) to make sure the logo component does not get re-render but it is still reanimated anyway. Might need to debug at library level so will pull this issue out of 1.1.0 and will come back and have a look again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bapairaew