Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit HTML semantic #10

Open
bapairaew opened this issue Jul 19, 2021 · 0 comments
Open

Revisit HTML semantic #10

bapairaew opened this issue Jul 19, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@bapairaew
Copy link
Owner

bapairaew commented Jul 19, 2021 •
edited
Loading

At some point, HTML semantic were completely neglected and this ended up in quite a mess. In order to play nice with SEO, bots, and screen reader and for the sake of a11y. Please have a revisit on the whole application HTML semantic.

Some points you might want to start looking at

  • TransferablePlayer is button but there are a lot divs inside
  • Heading hierarchy
  • Does radio group for each profile on settings modal make sense?
  • Does Team Planner tabs semantic make sense?
@bapairaew bapairaew added the enhancement New feature or request label Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bapairaew