Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Looking for maintainers #213

Open
baopham opened this issue Jan 21, 2020 · 31 comments
Open

Looking for maintainers #213

baopham opened this issue Jan 21, 2020 · 31 comments

Comments

@baopham
Copy link
Owner

baopham commented Jan 21, 2020

I've been away for quite some time due to not having enough bandwidth. I'm not sure what my bandwidth will be like for the next few months so would love to get some help out there.

Let me know if you're interested. I'm hoping to find someone who would be super familiar with PHP, Laravel, DynamoDB and have passion for clean code (with tests :) ).
This was referenced Jan 21, 2020
Closed
Merged
@rennokki
Copy link
Collaborator

I have forked your repo on my profile a while ago. I can take time to work with it.

@JackPriceBurns
Copy link
Collaborator

JackPriceBurns commented Jan 21, 2020 •
edited
Loading

I would be willing to help maintain this package. I will be using this project actively in a future project of mine, I also already have a few improvements I'd like to make.

@baopham
Copy link
Owner Author

baopham commented Jan 21, 2020

Awesome! Let me leave this open for a few days and then we finalize. I also need to sort out Travis / Scrutinizer accounts and create a channel (probably Slack) for us to communicate.

@baopham
Copy link
Owner Author

baopham commented Feb 1, 2020

I just added you two to the collaborators list. Let's try to come up with a way to collaborate (e.g. when to accept PR, when to make a new release, channel to discuss things)?

@JackPriceBurns
Copy link
Collaborator

Sounds good, do we want to make a slack?

@baopham
Copy link
Owner Author

baopham commented Feb 1, 2020 via email

@JackPriceBurns
Copy link
Collaborator

Can you send me an invite to [email protected] please 🙂

@baopham
Copy link
Owner Author

baopham commented Feb 3, 2020 via email

@zoe-edwards
Copy link
Collaborator

I’m more than happy to help out triage issues, this repo is very important to me!

@baopham
Copy link
Owner Author

baopham commented Feb 8, 2020 •
edited by zoe-edwards
Loading

Thanks @zoe-edwards ! I added you to the repo. Feel free to join our Slack channel too :)

@katakutu
Copy link

can add me to this repo thanks

@baopham
Copy link
Owner Author

baopham commented Mar 28, 2020 •
edited
Loading

@katakutu done. Send me an email if you want an invite to our Slack channel :) Thank you!

@ghost
Copy link

ghost commented Aug 21, 2020

Could I be invited to the Slack? [email protected]

@AidanLaycock
Copy link

Hi, could I be invited to the slack as I'd like to get more involved! - [email protected]

@xengulai
Copy link

Can I get invited to the Slack? I'm working on a feature and have some questions. jaysen [at] jaysen [dot] net

@JackPriceBurns
Copy link
Collaborator

Hey @xengulai, I've send an invite!

@thebatclaudio
Copy link
Contributor

Hello, can I get invited to Slack? [email protected]

@thebatclaudio
Copy link
Contributor

Hello to everyone in this thread, someone can review and accept this PR #254 ?
I've been waiting for over a month. Is this repository maintained or is it better to fork and publish it again on packagist? Thank you

@nelson6e65
Copy link
Collaborator

nelson6e65 commented Feb 8, 2023 •
edited
Loading

Is this project abandoned? I'd like to contribute to it.

@JackPriceBurns
Copy link
Collaborator

I think this project is largely abandoned, I tried keeping it alive for a while but I no longer use Laravel in my day to day work and haven't for a couple of years now. It's difficult maintaining the project when it's always a mission to run the tests and verify any changes. If you're interested in maintaining the project I'm sure @baopham would be happy making you a contributor as they did before

@baopham
Copy link
Owner Author

baopham commented Feb 16, 2023

yeah I'm not sure if the previous maintainers can still commit to supporting this project. If anyone is interested, let me know.

@nelson6e65
Copy link
Collaborator

I'm interested. I'm actively using it for the moment. I would like to add some improvements, not sure about to be the main mainteiner. Anyway, I would like to improve support for active versions of Laravel.

I have one project using Laravel 5.8, but there are plans to upgrade it to a recent version.

With a security support policy, we should only support versions already being supported by Laravel team and maybe a popular version (like me, using 5.8 😅).

I can help in long term with:

  • GitHub Actions (initially by moving the current TravisCI),
  • Improve code style (PHPCS)
  • Improve tests, PHPUnit (and maybe moving to PestPHP gradually 🤔)
  • Improve codebase with new PHP versions flavours, as possible.
  • Some minor revisions of features/fixes until I get some experience in this cosebase.

@baopham
Copy link
Owner Author

baopham commented Feb 17, 2023

I'm interested. I'm actively using it for the moment. I would like to add some improvements, not sure about to be the main mainteiner. Anyway, I would like to improve support for active versions of Laravel.

I have one project using Laravel 5.8, but there are plans to upgrade it to a recent version.

With a security support policy, we should only support versions already being supported by Laravel team and maybe a popular version (like me, using 5.8 😅).

I can help in long term with:

  • GitHub Actions (initially by moving the current TravisCI),
  • Improve code style (PHPCS)
  • Improve tests, PHPUnit (and maybe moving to PestPHP gradually 🤔)
  • Improve codebase with new PHP versions flavours, as possible.
  • Some minor revisions of features/fixes until I get some experience in this cosebase.

awesome! I added you as a contributor. Love the plan 🙂

@katakutu
Copy link

katakutu commented Feb 17, 2023 via email

@zoe-edwards
Copy link
Collaborator

zoe-edwards commented Feb 17, 2023 •
edited
Loading

I’m still about – I’ve been answering/closing comments but I don’t know too much about the internals to be comfortable approving PRs etc (but I have changed my name if you don’t recongise me!)

@nelson6e65
Copy link
Collaborator

Hello, @baopham @zoe-edwards . I was preparing my local environment, but I got some troubles with the local DynamoDB database. 😅

Can I have some help on this? I'll have this Saturday to try again. (Should we enable Discussions? 👀)

@zoe-edwards
Copy link
Collaborator

It’s not really something I’ve ever tried to do @nelson6e65, I’d recommend just using AWS for this as it’s quite inexpensive and more reliable.

@nelson6e65
Copy link
Collaborator

It is not necessary to use live version. Local version is enough. Actually, as it will be integrated into local and CI tests, it should not rely on any actual account having DynamoDB enabled. 😅

I installed the Docker version and seems to work, but my problem was about how to use the initialized database for testing. Maybe I'm missing a parameter to set up the database to use (as used with the bin located at /dynamodb_local directory). 🤔

@thebatclaudio
Copy link
Contributor

thebatclaudio commented Feb 24, 2023 •
edited
Loading

Hello people,
I would like to become a maintainer too!

@nelson6e65 I have some problems too: I can configure local DynamoDB, but when i run phpunit I receive an error:

PHP Fatal error:  During inheritance of ArrayAccess: Uncaught ErrorException: Return type of Illuminate\Http\Request::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/claudio/PhpstormProjects/laravel-dynamodb-github/vendor/laravel/framework/src/Illuminate/Http/Request.php:637

Maybe we should fix also tests (I never made tests, so I can be wrong)

EDIT:
I read that you would like to implement PHPPest, if you want I can try to help you (and use this opportunity to learn how to make tests)

@nelson6e65
Copy link
Collaborator

Hello people, I would like to become a maintainer too!

@nelson6e65 I have some problems too: I can configure local DynamoDB, but when i run phpunit I receive an error:

PHP Fatal error:  During inheritance of ArrayAccess: Uncaught ErrorException: Return type of Illuminate\Http\Request::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /home/claudio/PhpstormProjects/laravel-dynamodb-github/vendor/laravel/framework/src/Illuminate/Http/Request.php:637

Yes, this library seems not be tested against PHP 8 yet. Feel free to create an issue about it.

Maybe we should fix also tests (I never made tests, so I can be wrong)

EDIT: I read that you would like to implement PHPPest, if you want I can try to help you (and use this opportunity to learn how to make tests)

Of course! I'm also enabling GitHub Actions for running these tests. Just make sure to open an issue about the bug/feature before working hard in a PR.

@thebatclaudio
Copy link
Contributor

thebatclaudio commented Apr 2, 2024 •
edited
Loading

Hey @baopham @nelson6e65,
can I become a mantainer too? I usually work with Laravel and DynamoDB so I can help you to keep the project updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@zoe-edwards @baopham @thebatclaudio @JackPriceBurns @xengulai @nelson6e65 @katakutu @AidanLaycock @rennokki