Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow shorter resource names for kubectl volsync and verify length not surpassing 63 char limit #1075

Open
clushie opened this issue Jan 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@clushie
Copy link

clushie commented Jan 29, 2024

Describe the feature you'd like to have.
My namespace is 35 characters long, the PVC in addition also 10-15 characters.

Running
kubectl volsync migration create --pvcname prod-demo--ji63816-terraform-module/blob --capacity 10Gi --storageclass gp2 -r md-blob

I'll end in a situation as such:

Service "volsync-rsync-dst-prod-demo--ji63816-terraform-module-blob-migration-dest" is invalid: metadata.name: Invalid value: "volsync-rsync-dst-prod-demo--ji63816-terraform-module-blob-migration-dest": must be no more than 63 characters

What is the value to the end user? (why is it a priority?)
Long resource names will hit the limit, making it impossible to use the plugin

How will we know we have a good solution? (acceptance criteria)
Automatically truncate resource names to less than 63 characters, for example by using a short-id.

@clushie clushie added the enhancement New feature or request label Jan 29, 2024
tesshuflower added a commit to tesshuflower/volsync that referenced this issue Apr 29, 2024
- Also add --rdname cli flag

Fixes: backube#1075

Signed-off-by: Tesshu Flower <[email protected]>
tesshuflower added a commit to tesshuflower/volsync that referenced this issue Sep 17, 2024
- Also add --rdname cli flag

Fixes: backube#1075

Signed-off-by: Tesshu Flower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant