Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault: Kv1 hardcoded path prevents use of Kv2 secrets #1776

Open
2 tasks done
ellipsis-me opened this issue Oct 28, 2024 · 3 comments
Open
2 tasks done

vault: Kv1 hardcoded path prevents use of Kv2 secrets #1776

ellipsis-me opened this issue Oct 28, 2024 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ellipsis-me
Copy link

ellipsis-me commented Oct 28, 2024

Plugin Name

@backstage-community/plugin-vault

📜 Description

Here I see a problem trying to use Kv2 secrets, the v1/secrets/ path does not allow the use of Kv2 secrets as the Official Docs mention here, the snippet above must be changed in case the use of Kv2 secrets to accomplish the right path /:secret-mount-path/data/:path?version=:version-number, As we can see, to use Kv2, this v1/secrets/ must become this :secret-mount-path/data/. In my tests, I got that happening /api/vault/v1/secrets/***-secret?engine=***, the engine is being used as query params which the Vault API does not allow.

👍 Expected behavior

The correct validation of the plugin while using Kv2 secrets, as the documentation shows.

👎 Actual Behavior with Screenshots

In my tests, I got that happening /api/vault/v1/secrets/***-secret?engine=***, the engine is being used as query params which the Vault API does not allow for Kv2 secrets, or Kv1 in other mountpaths besides the default secrets hardcoded.

👟 Reproduction steps

Try to use Kv2 secrets, or Kv1 in other mountpaths besides the default secrets.

📃 Provide the context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

Yes I am willing to submit a PR!

@ellipsis-me ellipsis-me added the bug Something isn't working label Oct 28, 2024
@nickboldt nickboldt added the help wanted Extra attention is needed label Nov 5, 2024
@vinzscam
Copy link
Member

@ellipsis-me would you like to be assigned?

@ellipsis-me
Copy link
Author

@vinzscam Ok, I'll make some changes and request for your review.

@AdrianKrajewski001
Copy link

@ellipsis-me We encountered the same problem. Maybe I can help you in some way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants