Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update landing page examples #2750

Merged
merged 3 commits into from
Nov 8, 2024
Merged

update landing page examples #2750

merged 3 commits into from
Nov 8, 2024

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 3, 2023

Closes #2551

@netlify
Copy link

netlify bot commented Mar 3, 2023 •
edited
Loading

✅ Deploy Preview for babel ready!

Name Link
🔨 Latest commit 5f13edf
🔍 Latest deploy log https://app.netlify.com/sites/babel/deploys/672e847b2c4a0700082c0e59
😎 Deploy Preview https://deploy-preview-2750--babel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@liuxingbaoyu
Copy link
Member

These few examples don't look very good.
The output of the decorator is very, very long and completely unreadable.
The pipeline-operator is not that famous.
record-and-tuple relies entirely on polyfills.

Unfortunately I didn't think of a good example either.

@JLHwung JLHwung mentioned this pull request Nov 8, 2024
Closed
@JLHwung JLHwung force-pushed the update-landing-page-examples branch from 1bdc0d3 to 11ae820 Compare November 8, 2024 20:57
@netlify Netlify
Copy link

netlify bot commented Nov 8, 2024 •
edited
Loading

✅ Deploy Preview for babel-next ready!

Name Link
🔨 Latest commit 5f13edf
🔍 Latest deploy log https://app.netlify.com/sites/babel-next/deploys/672e847b3788650008693899
😎 Deploy Preview https://deploy-preview-2750--babel-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JLHwung
Copy link
Contributor Author

JLHwung commented Nov 8, 2024

I have removed decorators and pipeline examples. The new examples are from ES2025 and stage 3 explicit-resource-management proposal. Please take a look.

liuxingbaoyu
liuxingbaoyu approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Non-blocking: Would proposal-throw-expressions be better than proposal-do-expressions?

@JLHwung
Copy link
Contributor Author

JLHwung commented Nov 8, 2024

I am fine with either proposal, as long as we showcase something still in early stage. That said, I have updated the examples for throw expressions.

@JLHwung JLHwung merged commit 2e87c3a into babel:main Nov 8, 2024
4 checks passed
@JLHwung JLHwung deleted the update-landing-page-examples branch November 8, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

@nicolo-ribaudo nicolo-ribaudo Awaiting requested review from nicolo-ribaudo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lol the demo does nothing
2 participants
@JLHwung @liuxingbaoyu