don't run mypy on nonexistent samples dir, fix pip install for tox (Azure#31738)

Author: kristapratico

eng/tox/run_mypy.py

@@ -76,19 +76,25 @@
             f"Package {package_name} opts-out of mypy check on samples."
         )
     else:
-        sample_code = [
-            *commands,
-            "--check-untyped-defs",
-            "--follow-imports=silent",
-            os.path.join(args.target_package, "samples")
-        ]
-        try:
+        # check if samples dir exists, if not, skip sample code check
+        if not os.path.exists(os.path.join(args.target_package, "samples")):
             logging.info(
-                f"Running mypy commands on sample code: {sample_code}"
+                f"Package {package_name} does not have a samples directory."
             )
-            check_call(sample_code)
-        except CalledProcessError as sample_err:
-            sample_code_error = sample_err
+        else:
+            sample_code = [
+                *commands,
+                "--check-untyped-defs",
+                "--follow-imports=silent",
+                os.path.join(args.target_package, "samples")
+            ]
+            try:
+                logging.info(
+                    f"Running mypy commands on sample code: {sample_code}"
+                )
+                check_call(sample_code)
+            except CalledProcessError as sample_err:
+                sample_code_error = sample_err
 
     if args.next and in_ci() and is_check_enabled(args.target_package, "mypy") and not is_typing_ignored(package_name):
         if src_code_error or sample_code_error:

tools/azure-sdk-tools/gh_tools/vnext_issue_creator.py

@@ -114,7 +114,7 @@ def create_vnext_issue(package_name: str, check_type: Literal["mypy", "pylint",
         f"\n**{check_type.capitalize()} errors:** [Link to build ({today.strftime('%Y-%m-%d')})]({build_link})"
         f"\n**How to fix:** Run the `next-{check_type}` tox command at the library package-level and resolve "
         f"the {error_type} errors.\n"
-        f"1) `../{package_name}>pip install tox<5`\n"
+        f"1) `../{package_name}>pip install \"tox<5\"`\n"
         f"2) `../{package_name}>tox run -e next-{check_type} -c ../../../eng/tox/tox.ini --root .`\n\n"
         f"See the {guide_link} for more information."
     )