mgmt, bug fix, ResourceManager.httpPipeline not set (Azure#28111)

Author: weidongxu-microsoft

sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/implementation/VirtualMachineImpl.java

@@ -192,7 +192,7 @@ class VirtualMachineImpl
     private final Map<String, DeleteOptions> secondaryNetworkInterfaceDeleteOptions = new HashMap<>();
 
     // Snapshot of the updateParameter when update() is called, used to compare whether there is modification to VM during updateResourceAsync
-    VirtualMachineUpdateInner updateParameterSnapshotOnUpdate;
+    private VirtualMachineUpdateInner updateParameterSnapshotOnUpdate;
     private static final SerializerAdapter SERIALIZER_ADAPTER =
         SerializerFactory.createDefaultManagementSerializerAdapter();
 
@@ -229,7 +229,7 @@ class VirtualMachineImpl
     public VirtualMachineImpl update() {
         updateParameterSnapshotOnUpdate = this.deepCopyInnerToUpdateParameter();
         return super.update();
-    };
+    }
 
     @Override
     public Mono<VirtualMachine> refreshAsync() {

sdk/resourcemanager/azure-resourcemanager-resources/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## 2.14.0-beta.1 (Unreleased)
 
+### Bugs Fixed
+
+- Fixed a bug that `ResourceManager.pipeline()` be `null`.
+
 ### Other Changes
 
 #### Dependency Updates

sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/com/azure/resourcemanager/resources/fluentcore/arm/Manager.java

@@ -18,7 +18,7 @@ public abstract class Manager<InnerT> implements HasServiceClient<InnerT> {
     private ResourceManager resourceManager;
     private final String subscriptionId;
     private final AzureEnvironment environment;
-    private final HttpPipeline httpPipeline;
+    private HttpPipeline httpPipeline;
 
     private final InnerT innerManagementClient;
 
@@ -32,6 +32,7 @@ public abstract class Manager<InnerT> implements HasServiceClient<InnerT> {
     protected Manager(HttpPipeline httpPipeline, AzureProfile profile, InnerT innerManagementClient) {
         this.httpPipeline = httpPipeline;
         if (httpPipeline != null) {
+            // ResourceManager sends httpPipeline=null to avoid recursive
             this.resourceManager = ResourceManager.authenticate(httpPipeline, profile).withDefaultSubscription();
         }
         this.subscriptionId = profile.getSubscriptionId();
@@ -65,6 +66,10 @@ public AzureEnvironment environment() {
      */
     protected final void withResourceManager(ResourceManager resourceManager) {
         this.resourceManager = resourceManager;
+        if (this.httpPipeline == null) {
+            // fill httpPipeline from resourceManager
+            this.httpPipeline = resourceManager.serviceClient().getHttpPipeline();
+        }
     }
 
     /**

sdk/resourcemanager/azure-resourcemanager/src/test/java/com/azure/resourcemanager/ManagerLiveTests.java

@@ -35,6 +35,7 @@
 import com.azure.resourcemanager.storage.StorageManager;
 import com.azure.resourcemanager.test.ResourceManagerTestBase;
 import com.azure.resourcemanager.trafficmanager.TrafficManager;
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
 import java.time.temporal.ChronoUnit;
@@ -99,5 +100,8 @@ public void testAuthentication() {
         SqlServerManager.authenticate(httpPipeline, profile()).sqlServers().list().stream().count();
         StorageManager.authenticate(httpPipeline, profile()).storageAccounts().list().stream().count();
         TrafficManager.authenticate(httpPipeline, profile()).profiles().list().stream().count();
+
+        Assertions.assertNotNull(AzureResourceManager.authenticate(httpPipeline, profile()).withDefaultSubscription()
+            .genericResources().manager().httpPipeline());
     }
 }