Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#964 breaking build #966

Open
Kitzunu opened this issue Jun 5, 2024 · 3 comments
Open

#964 breaking build #966

Kitzunu opened this issue Jun 5, 2024 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@Kitzunu
Copy link
Member

Kitzunu commented Jun 5, 2024 •
edited
Loading

#964 Reverted.

Introduced build errors https://github.com/azerothcore/wiki/actions/runs/9332665923/job/25688789413

Did not have time to check them and fix them yet. So had to revert the changes to be fixed later.
@Kitzunu Kitzunu added the help wanted Extra attention is needed label Jun 5, 2024
@Kitzunu Kitzunu changed the title [Feature Request]: (Replace this text with a representative title) #964 breaking build Jun 16, 2024
@TheSCREWEDSoftware
Copy link
Contributor

I never got the nofication of this, I can take a look at it and see if i can figure it out what i did wrong and causing errors.

@TheSCREWEDSoftware
Copy link
Contributor

@Kitzunu correct me wrong. Was my commit build that was giving issues or something after that's causing issues and it was revertered to my commit?

@Kitzunu
Copy link
Member Author

Kitzunu commented Sep 17, 2024

4c6ae77 makes it fail. The logs are too old so they don't exist.

build is not tested on PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheSCREWEDSoftware @Kitzunu