Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: A guide for file ItemLimitCategory.dbc #854

Open
Lerduzz opened this issue Jan 3, 2023 · 7 comments
Open

[Feature Request]: A guide for file ItemLimitCategory.dbc #854

Lerduzz opened this issue Jan 3, 2023 · 7 comments

Comments

@Lerduzz
Copy link

Lerduzz commented Jan 3, 2023

Is your feature request related to a problem? Please describe.

I am trying to fix this AC issue and need more documentation:
azerothcore/azerothcore-wotlk#10986

Describe the solution you'd like

I need to know what binary flags can be used in the field "Flags".

Describe alternatives you've considered

To fix that issue I am trying to create an Item Group with all Ashen Verdict rings and limit to only 1 ring of that in your inventory (There are 20 rings).

Additional context

No response

@Lerduzz
Copy link
Author

Lerduzz commented Jan 3, 2023

This is related to AC DB table itemlimitcategory_dbc

@Lerduzz
Copy link
Author

Lerduzz commented Jan 3, 2023

I am contributor in AC project.

@Helias
Copy link
Member

Helias commented Jan 3, 2023

Working on Keira3 and AoWoW I saw that ItemCategory defines if:

The item category should define this, I think that you can understand it also analyzing some gems of the warlock and checking it's limit category

Hope this can help, if you want to view these items and item category you can always use Keira3 and/or AoWoW

@Lerduzz
Copy link
Author

Lerduzz commented Jan 3, 2023

Thanks @Helias, I found the correct flag for LimitCategory but when I go to complete the quest the game client crashes.

Luckily, I found another solution for the quest that has problems.

I am forcing the CombatStop() to temporarly fix that. Because the BUG happens when you have the ring equipped, you are in combat and then the quest script can not remove the quest item.

CS

@Lerduzz
Copy link
Author

Lerduzz commented Jan 3, 2023

That is the file PlayerQuest.cpp

@Lerduzz
Copy link
Author

Lerduzz commented Jan 3, 2023

To improve this solution, you must first check if the item required by the quest is equipped and in a slot that cannot be unequipped in combat. But I still don't know how to do that. That's why I haven't uploaded a pull request.

@Helias
Copy link
Member

Helias commented Jan 3, 2023

May you can start to open the PR as draft and add the label "Needs Help", someone could check it and give you some hints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants