Skip to content

Commit f3c59a0

Browse files
authored
fix(CI): re-enable -Werror compile flag (#256)
1 parent 7511f38 commit f3c59a0

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

.github/workflows/core-build-base.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ jobs:
5858
-DCMAKE_BUILD_TYPE="Release" \
5959
-DCMAKE_CXX_COMPILER_LAUNCHER="ccache" \
6060
-DCMAKE_C_COMPILER_LAUNCHER="ccache" \
61+
-DCMAKE_C_FLAGS="-Werror" \
62+
-DCMAKE_CXX_FLAGS="-Werror" \
6163
-DLUA_VERSION=${{ inputs.lua_version }}
6264
make -j$(nproc)
6365
cd ..

src/LuaEngine/lmarshal.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ static void mar_encode_value(lua_State *L, mar_Buffer *buf, int val, size_t *idx
204204
}
205205
else {
206206
mar_Buffer rec_buf;
207-
unsigned int i;
207+
unsigned char i;
208208
lua_Debug ar;
209209
lua_pop(L, 1); /* pop nil */
210210

src/LuaEngine/methods/MapMethods.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,13 +358,13 @@ namespace LuaMap
358358
*/
359359
int GetCreaturesByAreaId(lua_State* L, Map* map)
360360
{
361-
uint32 areaId = Eluna::CHECKVAL<uint32>(L, 2, -1);
361+
int32 areaId = Eluna::CHECKVAL<int32>(L, 2, -1);
362362
std::vector<Creature*> filteredCreatures;
363363

364364
for (const auto& pair : map->GetCreatureBySpawnIdStore())
365365
{
366366
Creature* creature = pair.second;
367-
if (areaId == -1 || creature->GetAreaId() == areaId)
367+
if (areaId == -1 || creature->GetAreaId() == (uint32)areaId)
368368
{
369369
filteredCreatures.push_back(creature);
370370
}

0 commit comments

Comments
 (0)