fix(lua-engine): update function call to match core API #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested this with the latest version of AzerothCore ? |
Author
|
I apologize for the confusion.
The compilation of the latest AzerothCore version (azerothcore/azerothcore-wotlk) is functioning properly.
Previously, I was using the robot-enhanced AzerothCore (mod-playerbots/azerothcore-wotlk), which likely contained an error.
azerothcore-wotlk + mod-playerbots + mod-ale
The compilation process will report an error for the latest AzerothCore（）
After making the changes, the game runs smoothly with no compilation issues.
For example, scripts like super_hearthstone.lua work perfectly in the game.
The UnitModifierType enum type may have been removed or renamed in AzerothCore (mod-playerbots/azerothcore-wotlk).
I will notify the author of mod-playerbots to update AzerothCore.
thanks
…------------------ 原始邮件 ------------------
发件人: "azerothcore/mod-ale" ***@***.***>;
发送时间: 2025年12月5日(星期五) 晚上8:37
***@***.***>;
***@***.******@***.***>;
主题: Re: [azerothcore/mod-ale] fix(lua-engine): update function call to match core API (PR #351)
iThorgrim left a comment (azerothcore/mod-ale#351)
Have you tested this with the latest version of AzerothCore ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the incompatible function call in
UnitMethods.hto fix compilation errors.HandleStatFlatModifierwithHandleStatModifier.UnitModifierFlatType) do not exist in the current AzerothCore codebase, causing a fatal compilation error.mod-aleis now compatible with the core and compiles successfully.