feat: migrate from flat to hierarchical install strategy #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
migrate-install-strategy
branch
2 times, most recently
from
a3aa730 to
48520dd
Compare
Before this commit, we had two different installation layouts: * Cargo home produced an FHS-style installation layout, with binaries installed into the `bin` directory within an install prefix. * Env subdir and home subdir produced a flat installation layout, with binaries and all other files placed in a single directory. Going forward, it will be advantageous for us to have a unified strategy where we can predict the layout of an install directory no matter which path we're following. This doesn't just change the default, but also performs a migration: any binaries that this installer would install that exist in the old default path are migrated to the new path before the installation itself begins.
mistydemeo
force-pushed
the
migrate-install-strategy
branch
2 times, most recently
from
3eedce9 to
6c7a842
Compare
mistydemeo
force-pushed
the
migrate-install-strategy
branch
from
6c7a842 to
c15e565
Compare
|
closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, we had two different installation layouts:
bindirectory within an install prefix.Going forward, it will be advantageous for us to have a unified strategy where we can predict the layout of an install directory no matter which path we're following.
This doesn't just change the default, but also performs a migration: any binaries that this installer would install that exist in the old default path are migrated to the new path before the installation itself begins.
We'll want to make sure this gets some testing before merging, though the "ruin me" env var tests in CI should also give us some active testing.
Fixes #934.