Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subdirectory/Monorepo support? #870

Open
DenuxPlays opened this issue Mar 22, 2024 · 4 comments
Open

Subdirectory/Monorepo support? #870

DenuxPlays opened this issue Mar 22, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation feature request New feature or request
Milestone

Comments

@DenuxPlays
Copy link

Hey,
In one of my rust projects we use a monorepo.
I've wondered if it is possible to tell cargo-dist to run all the workflows within a sub directory?

@DenuxPlays DenuxPlays changed the title Subdirectory support? Subdirectory/Monorepo support? Mar 23, 2024
DenuxPlays added a commit to financrr/financrr-app that referenced this issue Mar 23, 2024
@ashleygwilliams
Copy link
Member

@DenuxPlays hey! we do support this. a good example is how libsql uses us. the primary tool that they use is that they "namespace" the tag that they release libsql-server with, and they configure cargo-dist using the "tag-namespace" config to recognize it.

here's a link to the "tag-namespace" docs: https://opensource.axo.dev/cargo-dist/book/reference/config.html#tag-namespace

and here's a link to the libsql monorepo if you are curious about an example! https://github.com/tursodatabase/libsql/blob/main/.github/workflows/libsql-server-release.yml

@DenuxPlays
Copy link
Author

@DenuxPlays hey! we do support this. a good example is how libsql uses us. the primary tool that they use is that they "namespace" the tag that they release libsql-server with, and they configure cargo-dist using the "tag-namespace" config to recognize it.

here's a link to the "tag-namespace" docs: https://opensource.axo.dev/cargo-dist/book/reference/config.html#tag-namespace

and here's a link to the libsql monorepo if you are curious about an example! https://github.com/tursodatabase/libsql/blob/main/.github/workflows/libsql-server-release.yml

That sounds awesome.
Our release procedure has changed a little bit I will have to look into if we can implement cargo-dist in it.

@Gankra Gankra added the feature request New feature or request label Aug 8, 2024
@Gankra
Copy link
Contributor

Gankra commented Aug 8, 2024

development note: we've mostly refactored the code in preparation for this, the last thing that needs to be done is changing the release.yml template to support the various dirs it works with being in non-default locations. This requires additional piping of relevant values.

In the process we'll probably fix the issue with us hardcoding the target dir

@Gankra
Copy link
Contributor

Gankra commented Aug 22, 2024

Hmm I am realizing that now that we have a dist-workspace.toml which you can drop in the root and point at other subdirs, we don't necessarily need to natively support the actual workspace root not being in the repo root. So it's possibly a good idea to close this out with a recommendation that people who need this should use that?

@ashleygwilliams ashleygwilliams added the documentation Improvements or additions to documentation label Sep 9, 2024
zjp-CN added a commit to os-checker/RAPx that referenced this issue Oct 14, 2024
because cargo-dist doesn't support subdirectories:
see axodotdev/cargo-dist#870
@ashleygwilliams ashleygwilliams modified the milestones: 0.24.0, 0.25.0 Oct 22, 2024
@ashleygwilliams ashleygwilliams modified the milestones: 0.25.0, 0.26.0 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants