Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Silicon (M1) macOS runners (aarch64) #864

Open
xoolive opened this issue Mar 20, 2024 · 3 comments
Open

Apple Silicon (M1) macOS runners (aarch64) #864

xoolive opened this issue Mar 20, 2024 · 3 comments

Comments

@xoolive
Copy link

xoolive commented Mar 20, 2024

So it seems Apple Silicon (M1) macOS runners are now available on GitHub Actions.
https://github.com/orgs/community/discussions/69211

In the limitation section of https://opensource.axo.dev/cargo-dist/book/ci/github.html#bring-your-own-release you say:

GitHub currently only provides x86_64 macOS runners. When you request packages, the Intel versions will always be installed regardless of build targets. While Apple Silicon builds can use CLI tools installed this way, you will not be able to build software for Apple Silicon if it requires C libraries from Homebrew.

I guess things can be easily adapted so that releases with dependencies from Homebrew now work!

@xoolive
Copy link
Author

xoolive commented Mar 20, 2024

Would it be enough to just edit that line (with macos-14)?

const GITHUB_MACOS_ARM64_RUNNER: &str = "macos-12";

@ashleygwilliams
Copy link
Member

so, i'll let @mistydemeo or @Gankra chime in, but iirc the issue here has to do with the minimum OS installed on each runner. unfortunately the macos-14 runner has a newer OS- so defaulting to it would actually be a breaking change- dropping compatibility for binaries that we currently can support with macos-12.

if you want you can always override the defaults using the github runner config: https://opensource.axo.dev/cargo-dist/book/reference/config.html#github-custom-runners

we definitely need to update that comment to be more accurate tho (and explain what i've said here more thoroughly)

@ashleygwilliams
Copy link
Member

(oh also i think releases with dependencies from homebrew work now? @mistydemeo correct me if i'm wrong on that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants