Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create tests that stress manifest merging #851

Open
Gankra opened this issue Mar 13, 2024 · 0 comments
Open

create tests that stress manifest merging #851

Gankra opened this issue Mar 13, 2024 · 0 comments
Labels
question Further information is requested

Comments

@Gankra
Copy link
Contributor

Gankra commented Mar 13, 2024

in #848 we're more aggressively leaning on info passing through the manifest and getting merged, but no tests actually check that manifest merging works right.

This is annoying to Properly test but that PR at least teaches --artifacts=lies to produce proper fake data, so we can perhaps write a test that basically runs:

  • --artifacts=lies --target=abc
  • --artifacts=lies --target=cde

And check that they combine right...? (Unclear if this will work exactly right, since lies is "like --artifacts=all" and tries to turn on everything...)

Or just straight up write some normal unit tests.

@Gankra Gankra added the question Further information is requested label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant