You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in #848 we're more aggressively leaning on info passing through the manifest and getting merged, but no tests actually check that manifest merging works right.
This is annoying to Properly test but that PR at least teaches --artifacts=lies to produce proper fake data, so we can perhaps write a test that basically runs:
--artifacts=lies --target=abc
--artifacts=lies --target=cde
And check that they combine right...? (Unclear if this will work exactly right, since lies is "like --artifacts=all" and tries to turn on everything...)
Or just straight up write some normal unit tests.
The text was updated successfully, but these errors were encountered:
in #848 we're more aggressively leaning on info passing through the manifest and getting merged, but no tests actually check that manifest merging works right.
This is annoying to Properly test but that PR at least teaches --artifacts=lies to produce proper fake data, so we can perhaps write a test that basically runs:
And check that they combine right...? (Unclear if this will work exactly right, since lies is "like --artifacts=all" and tries to turn on everything...)
Or just straight up write some normal unit tests.
The text was updated successfully, but these errors were encountered: