Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't strictly rely on github releases to tag with dispatch-releases #1018

Open
Gankra opened this issue May 7, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@Gankra
Copy link
Contributor

Gankra commented May 7, 2024

The dispatch-releases feature implicitly relies on the fact that GitHub Releases automatically creates a tag if you ask it to create a GitHub Release for a given tag name, which we do.

However when only hosting with axo Releases, that means we won't create a tag at all. Conceptually this is an easy fix. Just add the following here:

    {{%- elif workflow_dispatch or release_branch %}}
      # TODO: if github releases are disabled AND we're using a non-tag-first workflow,
      # then we're responsible for creating and pushing the tag!
      - name: "tag commit"
        run: |
          git tag ${{ needs.plan.outputs.tag }}
          git push origin tag ${{ needs.plan.outputs.tag }}
    {{%- endif %}}

But the exact details of how we invoke git here might want to be refined.

@Gankra Gankra added the bug Something isn't working label May 7, 2024
@Gankra
Copy link
Contributor Author

Gankra commented May 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants