Port all tests to Junit-5 #239
Assignees
Labels
Comments
HannesWell
added a commit
to HannesWell/symja_android_library
that referenced
this issue
Jun 16, 2021
The removed test-suites contained all tests of their package (and one even of other packages). But those test-suites are not in used within the build and modern day IDE can execute all test-clases of a package as simple as a single test class. So there is no need for those test suites. And removing the test suites also simplifies the transition to JUnit-5.
1 task
HannesWell
added a commit
that referenced
this issue
Jun 16, 2021
The removed test-suites contained all tests of their package (and one even of other packages). But those test-suites are not in used within the build and modern day IDE can execute all test-clases of a package as simple as a single test class. So there is no need for those test suites. And removing the test suites also simplifies the transition to JUnit-5.
HannesWell
added a commit
to HannesWell/symja_android_library
that referenced
this issue
Jan 11, 2022
1 task
HannesWell
added a commit
that referenced
this issue
Jan 11, 2022
HannesWell
added a commit
to HannesWell/symja_android_library
that referenced
this issue
Feb 3, 2022
HannesWell
added a commit
that referenced
this issue
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment the library contains a mixture of Junit-5, JUnit-4 and even JUnit-3 tests.
Even it is possible to mix tests written against different JUnit versions I suggest to upgrade all tests to JUnit-5 to reduce complexity and styles how tests are written.
I'm already working on it and porting of most tests are straight forward.
But I have one question:
Many test packages that contain multiple test classes contain a Test-Suite that contains all tests of the package.
I think this is a convenience feature to execute all tests of the package at once.
But with modern day Eclipse versions it is possible to Run all tests in a package at once by right-clicking on the package in the Package-Explorer and selecting
Run as->JUnit test. I think there is an equivalent feature in other IDEs too.So the "package-Suite" is not necessary and only adds additional code. Furthermore Test-Suites are not supported before the upcoming JUnit 5.8.0 release which is currently only available as milestone release. Furthermore it looks like Eclipse does not yet recognize JUnit-5 tests suites reliably.
So even tough the package-suites can be ported to JUnit-5 already, I suggest to simply remove them for the sake of simplicity.
What do you think?
The text was updated successfully, but these errors were encountered: