This repository has been archived by the owner on Feb 18, 2025. It is now read-only.
consortium-v2: only return when failing to verify extraData #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 584db0f ("consortium-v2: move extraData check with contract into a function"), we refactor the code and mistakenly return even if we successfully verify extraData. Fix it by checking the error and only return if there is an error when verifying extraData.
|
seem good, retested in PBSS. |
huyngopt1994
approved these changes
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 584db0f ("consortium-v2: move extraData check with contract into a function"), we refactor the code and mistakenly return even if we successfully verify extraData. Fix it by checking the error and only return if there is an error when verifying extraData.