Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bedrock): (custom data sources) #1010

Open
1 of 2 tasks
ipa-tys opened this issue Mar 4, 2025 · 2 comments
Open
1 of 2 tasks

(bedrock): (custom data sources) #1010

ipa-tys opened this issue Mar 4, 2025 · 2 comments
Labels
backlog feature-request New feature or request

Comments

@ipa-tys
Copy link

ipa-tys commented Mar 4, 2025

Describe the feature

It seems that at the moment the bedrock module does not support custom data sources. This is also documented here:
https://awslabs.github.io/generative-ai-cdk-constructs/src/cdk-lib/bedrock/#vector-knowledge-base---data-sources

Would it be possible to add this feature? In python code, it is straightforward, cf. example below. I would also be happy to give it a try myself, but I would need some hints.

response = bedrock_agent_client.create_data_source(
    name = 'devkb',
    description = 'devdatasource',
    knowledgeBaseId = 'myid',
    dataSourceConfiguration = {
        "type": "CUSTOM"
    },
    vectorIngestionConfiguration = {
        "chunkingConfiguration": chunkingStrategyConfiguration
    }
)

Use Case

Custom data sources are an important feature for Bedrock Knowledge Bases for all but very standard use cases.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@ipa-tys ipa-tys added the needs-triage This issue or PR still needs to be triaged. label Mar 4, 2025
@krokoko
Copy link
Collaborator

krokoko commented Mar 4, 2025

Hi @ipa-tys , I can see that the type 'CUSTOM' is available in CloudFormation (cf https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-bedrock-datasource-datasourceconfiguration.html).
It would require to update the enum here and then probably exposing a new custom-data-source.ts to implement the related logic. I didn't play with that feature yet so not familiar with the specifics.
I will add it to the backlog, thank you !

@krokoko krokoko added feature-request New feature or request backlog and removed needs-triage This issue or PR still needs to be triaged. labels Mar 4, 2025
@ipa-tys
Copy link
Author

ipa-tys commented Mar 4, 2025

Hi @krokoko , thanks for the helpful and quick reply! I had a quick look, but as I'm not well-versed in TypeScript, I was not able to quickly contribute the feature myself. Would be great if someone else would be capable to pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants