Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CodeSeeeder cannot make bundles from code sourced from a path with '@' in the naming convention #266

Open
dgraeber opened this issue Oct 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@dgraeber
Copy link
Contributor

When using with SeedFarmer, if the path that houses the manifests is located under a node-compliant naming convention, CS cannot create a bundle due to an @ symbol in the full path.

For example, when using manifests sourced from an npm package, the manifests are located in a relative path like:

~/src/node_modules/@awssolutions/iwblueprints-poc/dummyblueprint/. When SeedFarmer fetches the module code from Git, the module code resides in a path such as:
~/src/node_modules/@awssolutions/iwblueprints-poc/dummyblueprint/seedfarmer.gitmodules/github.com_awslabs_idf-modules_release_1.6.0/modules/dummy/blank... to which CodeSeeder fails to properly create a bundle...

File "/XXXXXXX/aws-seed-group/.venv-latest/lib/python3.9/site-packages/aws_codeseeder/_bundle.py", line 145, in generate_bundle
generate_dir(out_dir=bundle_dir, dir=dir, name=name)
File "/XXXXXX/aws-seed-group/.venv-latest/lib/python3.9/site-packages/aws_codeseeder/_bundle.py", line 95, in generate_dir
raise ValueError(f"{name} ({absolute_dir}) is empty!")
ValueError: module (/src/node_modules/@awssolutions/iwblueprints-poc/dummyblueprint/seedfarmer.gitmodules/github.com_awslabs_idf-modules_release_1.6.0/modules/dummy/blank) is empty!
(.venv-latest) (base) ✘-1 ~/src/node_modules/@awssolutions/iwblueprints-poc/dummyblueprint [mainline ↓·3|…9⚑ 1]

@dgraeber dgraeber added the bug Something isn't working label Oct 29, 2024
@dgraeber
Copy link
Contributor Author

Fo reference later on..

Screenshot 2024-10-29 at 10 03 24 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant