Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage for servlet specification compliance #1278

Open
deki opened this issue Feb 4, 2025 · 0 comments
Open

Increase test coverage for servlet specification compliance #1278

deki opened this issue Feb 4, 2025 · 0 comments

Comments

@deki
Copy link
Collaborator

deki commented Feb 4, 2025

Currently there are two ways of mapping request events to servlet requests. The classic way is covered by tests using com.amazonaws.serverless.proxy.internal.testutils.AwsProxyRequestBuilder, the new way using Spring Cloud is tested in com.amazonaws.serverless.proxy.spring.AwsSpringHttpProcessingUtilsTests. The latter doesn't cover all cases that were already implemented in previous years, so we'd need to transfer the tests.

Ideally we'd leverage the official TCK https://github.com/jakartaee/servlet/tree/master/tck to some extend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant