From cb4e2acf3d8f707173fdb5df1f8ec73aaf80119d Mon Sep 17 00:00:00 2001 From: Josep Pon Farreny Date: Tue, 3 Dec 2024 22:35:38 +0100 Subject: [PATCH] fix: compile args not working on macOS --- setup.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/setup.py b/setup.py index 31c5b3fa..52db518a 100644 --- a/setup.py +++ b/setup.py @@ -52,9 +52,12 @@ def read_version(): gethostname = setuptools.Extension( "gethostname", - sources=["src/sagemaker_training/c/gethostname.c", "src/sagemaker_training/c/jsmn.c"], + sources=[ + "src/sagemaker_training/c/gethostname.c", + "src/sagemaker_training/c/jsmn.c", + ], include_dirs=["src/sagemaker_training/c"], - extra_compile_args=["-Wall", "-shared", "-export-dynamic", "-ldl"], + extra_compile_args=["-Wall", "-shared", "-Wl,-export-dynamic", "-ldl"], ) setuptools.setup( @@ -63,7 +66,9 @@ def read_version(): description="Open source library for creating containers to run on Amazon SageMaker.", packages=packages, package_dir={"sagemaker_training": "src/sagemaker_training"}, - py_modules=[os.path.splitext(os.path.basename(path))[0] for path in glob("src/*.py")], + py_modules=[ + os.path.splitext(os.path.basename(path))[0] for path in glob("src/*.py") + ], ext_modules=[gethostname], long_description=read("README.md"), long_description_content_type="text/markdown",