Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stabilize tryRemoveChild() #2267

Closed
pahud opened this issue May 17, 2024 · 2 comments · Fixed by #2497 · 4 remaining pull requests
Closed

stabilize tryRemoveChild() #2267

pahud opened this issue May 17, 2024 · 2 comments · Fixed by #2497 · 4 remaining pull requests

Comments

@pahud
Copy link

pahud commented May 17, 2024

This method was introduced in 2020 from this PR and aws-cdk-lib has some adoption. As it's still marked as experimental, we've seen customers having concern about that in production but we don't seem to have other methods to remove a child from a Node.

constructs/src/construct.ts

Lines 369 to 379 in 80aa122

/**
* Remove the child with the given name, if present.
*
* @returns Whether a child with the given name was deleted.
* @experimental
*/
public tryRemoveChild(childName: string): boolean {
if (!(childName in this._children)) { return false; }
delete this._children[childName];
return true;
}

Please stabilize this method and remove the @experimental tag.

@ArchitGajjar
Copy link

Hi @pahud - can I work on this issue ? this will be my first contribution into AWS :)

@mrgrain
Copy link
Contributor

mrgrain commented Oct 10, 2024

PRs are welcome!

@mergify mergify bot closed this as completed in #2497 Oct 11, 2024
@mergify mergify bot closed this as completed in 75f29f4 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment