Skip to content

Commit 0c57292

Browse files
Abhimanyu Siwachclaude
authored andcommitted
fix: Remove ExpectedBucketOwner parameter from create_bucket method
The ExpectedBucketOwner parameter is not supported by the S3 create_bucket API call. It is only valid for operations on existing buckets. This fix removes the parameter from both us-east-1 and regional bucket creation calls, resolving API errors during bucket creation. Changes: - Removed ExpectedBucketOwner from create_bucket() calls in s3.py - Updated test assertions to match corrected API calls Fixes #330 Related to PR #331 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 9714c81 commit 0c57292

File tree

2 files changed

+4
-10
lines changed
  • src/bedrock_agentcore_starter_toolkit/services
  • tests/services

2 files changed

+4
-10
lines changed

src/bedrock_agentcore_starter_toolkit/services/s3.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,9 @@ def create_s3_bucket(bucket_name: str, region: str, account_id: str) -> str:
6767

6868
try:
6969
if region == "us-east-1":
70-
s3.create_bucket(Bucket=bucket_name, ExpectedBucketOwner=account_id)
70+
s3.create_bucket(Bucket=bucket_name)
7171
else:
72-
s3.create_bucket(
73-
Bucket=bucket_name,
74-
CreateBucketConfiguration={"LocationConstraint": region},
75-
ExpectedBucketOwner=account_id,
76-
)
72+
s3.create_bucket(Bucket=bucket_name, CreateBucketConfiguration={"LocationConstraint": region})
7773

7874
s3.put_bucket_lifecycle_configuration(
7975
Bucket=bucket_name,

tests/services/test_s3.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ def test_create_bucket_us_east_1(self, mock_boto3_client):
124124
result = create_s3_bucket("test-bucket", "us-east-1", "123456789012")
125125

126126
assert result == "test-bucket"
127-
mock_s3.create_bucket.assert_called_once_with(Bucket="test-bucket", ExpectedBucketOwner="123456789012")
127+
mock_s3.create_bucket.assert_called_once_with(Bucket="test-bucket")
128128
mock_s3.put_bucket_lifecycle_configuration.assert_called_once()
129129

130130
@patch("bedrock_agentcore_starter_toolkit.services.s3.boto3.client")
@@ -137,9 +137,7 @@ def test_create_bucket_other_region(self, mock_boto3_client):
137137

138138
assert result == "test-bucket"
139139
mock_s3.create_bucket.assert_called_once_with(
140-
Bucket="test-bucket",
141-
CreateBucketConfiguration={"LocationConstraint": "us-west-2"},
142-
ExpectedBucketOwner="123456789012",
140+
Bucket="test-bucket", CreateBucketConfiguration={"LocationConstraint": "us-west-2"}
143141
)
144142
mock_s3.put_bucket_lifecycle_configuration.assert_called_once()
145143

0 commit comments

Comments
 (0)