Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning: logger gem being removed from default gems in Ruby 3.5 #3206

Open
1 task
blowfishpro opened this issue Mar 4, 2025 · 1 comment
Open
1 task
Labels
dependencies This issue is a problem in a dependency.

Comments

@blowfishpro
Copy link

Describe the bug

Similar to #2984

When running on ruby 3.4 this warning is displayed, indicating that this will break on ruby 3.5

aws-sdk-core-3.219.0/lib/seahorse/client/net_http/connection_pool.rb:8: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add logger to your Gemfile or gemspec to silence this warning.

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

No deprecation warning

Current Behavior

Deprecation warning indicating that aws-sdk-core will break in ruby 3.5

Reproduction Steps

ruby -r bundler/inline -e 'gemfile { gem "aws-sdk-core" }'

Possible Solution

Add logger gem to aws-sdk-core's dependencies

Additional Information/Context

Ruby commit that marked logger as to be removed from default gems: ruby/ruby@d7e558e

Gem name ('aws-sdk', 'aws-sdk-resources' or service gems like 'aws-sdk-s3') and its version

aws-sdk-core 3.219.0

Environment details (Version of Ruby, OS environment)

ruby 3.4.1 (2024-12-25 revision 48d4efcb85) +PRISM [arm64-darwin23]

@blowfishpro blowfishpro added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 4, 2025
@mullermp
Copy link
Contributor

mullermp commented Mar 4, 2025

Thanks for the heads up. We would have to add logger to our gemspecs in that case.

@mullermp mullermp added dependencies This issue is a problem in a dependency. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This issue is a problem in a dependency.
Projects
None yet
Development

No branches or pull requests

2 participants