-
Notifications
You must be signed in to change notification settings - Fork 621
Open
Labels
bugThis issue is a bug.This issue is a bug.p3This is a minor priority issueThis is a minor priority issuequeuedThis issues is on the AWS team's backlogThis issues is on the AWS team's backlog
Description
Describe the bug
The maxRetries configuration was added in remote credentials provider back in Jun 15, 2017 in
d2b251e
The configuration maxRetries
was changed to maxAttempts
in middleware-retry to be compliant with other SDKs and retry strategy #1244
This change wasn't done in credential providers though.
Proposed fix
- Add new configuration
maxAttempts
inRemoteProviderConfig
, so that it reuses the value from retry while fetching credentials. - Instead of deleting existing
maxRetries
, call it deprecated in favor of maxAttempts.
Additional context
The bug was noticed while debugging retry strategy options for RemoteProviderConfig requested in #2706
andre-araujo
Metadata
Metadata
Assignees
Labels
bugThis issue is a bug.This issue is a bug.p3This is a minor priority issueThis is a minor priority issuequeuedThis issues is on the AWS team's backlogThis issues is on the AWS team's backlog