Skip to content

Commit 3d47ad5

Browse files
snay2ec2-bot
andauthored
🥑🤖 v1.16.0 release prep (#600)
* Fix release script prompt when calling from a golang program For some reason, `read -p` doesn't properly print to stdout when invoked through golang's `exec.Command().Run()`, but `echo` does. Reading from stdin still works correctly. * 🥑🤖 v1.16.0 release prep 🤖🥑 Co-authored-by: ec2-bot 🤖 <[email protected]>
1 parent 3548931 commit 3d47ad5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

config/helm/aws-node-termination-handler/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ apiVersion: v2
22
name: aws-node-termination-handler
33
description: A Helm chart for the AWS Node Termination Handler.
44
type: application
5-
version: 0.17.0
6-
appVersion: 1.15.0
5+
version: 0.18.0
6+
appVersion: 1.16.0
77
kubeVersion: ">= 1.16-0"
88
keywords:
99
- aws

scripts/prepare-for-release

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,8 @@ EOM
235235
# gh actions cannot respond to prompts
236236
if [[ $RELEASE_PREP == true ]]; then
237237
while true; do
238-
read -p "🥑${BOLD}Do you wish to create the release prep PR? Enter y/n " yn
238+
echo -e "🥑${BOLD}Do you wish to create the release prep PR? Enter y/n"
239+
read -p "" yn
239240
case $yn in
240241
[Yy]* ) create_pr; break;;
241242
[Nn]* ) rollback; exit;;

0 commit comments

Comments
 (0)