Skip to content

Commit 1a97168

Browse files
author
Fawad Khaliq
authored
Fix jaeger tracing collector endpoint and tracer type (#379)
1 parent c087468 commit 1a97168

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pkg/inject/jaeger.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ import (
88
const jaegerEnvoyConfigTemplate = `
99
tracing:
1010
http:
11-
name: envoy.zipkin
11+
name: envoy.tracers.zipkin
1212
typed_config:
1313
"@type": type.googleapis.com/envoy.config.trace.v2.ZipkinConfig
1414
collector_cluster: jaeger
15-
collector_endpoint: "/api/v1/spans"
15+
collector_endpoint: "/api/v2/spans"
1616
collector_endpoint_version: HTTP_JSON
1717
shared_span_context: false
1818
static_resources:

pkg/inject/jaeger_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,11 @@ func Test_jaegerMutator_mutate(t *testing.T) {
108108
`cat <<EOF >> /tmp/envoy/envoyconf.yaml
109109
tracing:
110110
http:
111-
name: envoy.zipkin
111+
name: envoy.tracers.zipkin
112112
typed_config:
113113
"@type": type.googleapis.com/envoy.config.trace.v2.ZipkinConfig
114114
collector_cluster: jaeger
115-
collector_endpoint: "/api/v1/spans"
115+
collector_endpoint: "/api/v2/spans"
116116
collector_endpoint_version: HTTP_JSON
117117
shared_span_context: false
118118
static_resources:

0 commit comments

Comments
 (0)