Skip to content

feat(eval): add batch-evaluation simulate (dataset simulations) - #2000

Closed
jariy17 wants to merge 13 commits into
aws:refactorfrom
jariy17:feat/eval-batch-simulate
Closed

feat(eval): add batch-evaluation simulate (dataset simulations)#2000
jariy17 wants to merge 13 commits into
aws:refactorfrom
jariy17:feat/eval-batch-simulate

Conversation

@jariy17

@jariy17 jariy17 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

simulate replays a dataset through a runtime — one client-side invoke per scenario — then submits a StartBatchEvaluation over the sessions it created.
The service has no dataset data source, so the CLI creates the sessions and the service grades them.

CLI command structure

agentcore eval batch-evaluation
├── evaluate     (existing)
├── simulate     ← this PR
├── get
└── list

Flags (mirror runtime invoke):

Flag Req Notes
--runtime-id runtime to invoke per scenario
--qualifier endpoint qualifier (default DEFAULT)
--payload-template '{"prompt":"{input}"}' {input} = scenario input
--header ordered app header (repeatable)
--bearer-token CUSTOM_JWT bearer token
--user-id runtime user id
--dataset <path|id> local JSONL path or dataset id
--dataset-version with a dataset id
--evaluator evaluator id(s)
--name unique in the account
--description optional
--kms-key-arn encrypt eval data at rest

content-type / accept are hardcoded application/json.

How it works

  1. Load dataset — local JSONL path, or fetch by dataset id.
  2. Invoke agent per scenario — concurrent, one fresh client-generated session id per scenario. Multi-turn = sequential invokes on one session.
  3. Wait ~180s for span ingestion (spans must land before grading reads them).
  4. StartBatchEvaluationcloudWatchLogs scoped to those sessionIds + evaluationMetadata.sessionMetadata.
  5. Poll with agentcore eval batch-evaluation get.

Design decisions

  • Method on EvalClientsimulate is a method, no new class.
  • Extracted invokeRuntime free fns to src/core/invokeRuntime.ts — no sibling core.runtime.* calls, star graph preserved; RuntimeClient.invokeRuntime becomes a 1-line delegate.
  • Handler owns the public contract onlySimulateInput / SimulateResult are public; private helpers use local types (no handler-interface leaks inward).
  • Generalized renderJsonTemplate in src/io — JSON-safe {key} substitution, not eval-specific.
  • Session id client-generated — client-owned per AWS docs (min 33 chars; randomUUID() = 36), needed for microVM stickiness + multi-turn threading; matches the public bedrock_agentcore SDK rather than reading a response header.
  • Ctrl-C cancellableAbortSignal threaded through handler → core → invoke/sleep; aborts in-flight invokes, the dataset download, and the ingestion wait.

Testing

Live-verified in account 685197708687 / us-west-2, agent asdf_MyAgent-3s5axvBC6Q, evaluator Builtin.Helpfulness:

  • Single-turn job sim_live_1f9e-cbcc074b38COMPLETED, 2/2 sessions graded.
  • Multi-turn job sim_mt_2755-7517683065 (2-turn "remember 7 → recall it") → COMPLETED, 2/2 graded, 2 sessions scoped.

Automated:

  • bun test src/1383 pass; typecheck + oxlint clean.
  • Unit tests: src/io/template.test.ts, src/handlers/eval/batch-evaluation/simulate/simulate.test.tsx.

--help (captured via tui-harness):

Usage: agentcore eval batch-evaluation simulate [options]

replay a dataset against a runtime, then batch-evaluate the resulting sessions

Options:
  --runtime-id <runtime-id>              runtime id to invoke per scenario
  --qualifier <qualifier>                runtime endpoint qualifier (default DEFAULT)
  --payload-template <payload-template>  JSON payload template; {input} is the scenario input, e.g.
                                         {"prompt":"{input}"}
  --header <header...>                   an ordered application header (repeatable)
  --bearer-token <bearer-token>          CUSTOM_JWT bearer token (for JWT-auth runtimes)
  --user-id <user-id>                    runtime user id
  --dataset <dataset>                    dataset source: local JSONL path or a dataset id
  --dataset-version <dataset-version>    dataset version (with a dataset id)
  --evaluator <evaluator...>             evaluator id(s) to apply
  --name <name>                          batch evaluation name (unique in the account)
  --description <description>            optional description
  --kms-key-arn <kms-key-arn>            KMS key to encrypt evaluation data at rest
  -h, --help                             display help for command

Required-flag validation (captured via tui-harness, --name omitted):

$ agentcore eval batch-evaluation simulate --dataset /tmp/x.jsonl --runtime-id r --payload-template '{}' --evaluator E
Error: required option '--name <name>' not specified

@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 13, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.42159% with 199 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.12%. Comparing base (4d183dc) to head (80291f9).
⚠️ Report is 1 commits behind head on refactor.

Files with missing lines Patch % Lines
src/core/eval.tsx 65.23% 113 Missing ⚠️
src/core/eval/simulate.ts 4.70% 81 Missing ⚠️
src/handlers/eval/ondemand/evaluate/index.tsx 98.16% 2 Missing ⚠️
src/io/template.ts 91.30% 2 Missing ⚠️
src/core/invokeRuntime.ts 99.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #2000      +/-   ##
============================================
- Coverage     96.96%   96.12%   -0.84%     
============================================
  Files           364      370       +6     
  Lines         20758    21393     +635     
============================================
+ Hits          20127    20563     +436     
- Misses          631      830     +199     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Aug 13, 2026
@jariy17 jariy17 changed the title feat(eval): add batch-evaluation simulate (dataset replay) feat(eval): add batch-evaluation simulate (dataset simulations) Aug 14, 2026
jariy17 added 4 commits August 14, 2026 19:46
…ype example classes

Split the monolithic core.eval.simulate into two composable EvalClient calls the
handler orchestrates — invokeDataset (replay) then startBatchEvaluation (grade) —
and model each dataset type as a class that owns its parse + run + ground truth.

- src/core/eval/dataset/: types (Example interface, RunContext), predefined +
  simulated example classes, DatasetLoader (shape-classify → switch → new), and a
  generic runExamples pool. Replaces src/core/eval/simulate.ts.
- core.eval.invokeDataset returns { sessions, invoked, failed } with neutral inline
  ground truth; the batch-evaluation simulate handler wraps it as sessionMetadata and
  submits startBatchEvaluation. No Core method calls a sibling.
- readDatasetText reuses readLocalDatasetFile + downloadDatasetToTemp (drops the
  combined loadDatasetFile); dispatch is a build() switch whose non-exhaustiveness on a
  new DatasetSchemaType fails the build (no map, no assertNever).
- Carries the simulate fixes: sparse multi-turn ground truth keeps turn position
  (input.prompt per turn), both-row refusal, NotImplementedError for simulated,
  per-example failure isolation, 180s ingestion wait, AbortSignal, JSON-only.
- Tests: dataset unit tests + a golden snapshot of the inline ground-truth shape;
  handler test asserts the invokeDataset→startBatchEvaluation composition.
jariy17 and others added 4 commits August 18, 2026 20:32
… crashing

A JSONL line that is valid JSON but not an object (e.g. bare `null`) threw a
raw TypeError (`null is not an object`) when DatasetLoader dereferenced
`row.example_id`; the same happened in PredefinedExample for a non-object turn
entry (`turns: [null]`). Both now surface a clear InputValidationError at the
parse boundary. Adds guard tests plus behavior locks for CRLF endings, unicode
ids, empty assertions/trajectory omission, and `expected_response: ""`.
…data golden

runExamples: lock per-example failure isolation (one worker throws, the rest run
and are returned; firstError captured and non-Error throws wrapped), exactly-once
processing, the concurrency bound, and the empty-input case. Adds a golden
snapshot of the sessionMetadata the simulate handler builds, pinning the
`{ inline: gt }` wrapping and the omitted-member case for a session with no GT.
refactor(eval): invokeDataset + per-type example classes
@jariy17

jariy17 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #2032, which folds this replay path into the invokeDataset design (each example owns its invoker, passed into run()). Closing in favor of that.

@jariy17 jariy17 closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants