Skip to content

feat(project): wire dev handler - #1966

Merged
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler
Aug 17, 2026
Merged

feat(project): wire dev handler#1966
aidandaly24 merged 3 commits into
refactorfrom
feat/project-dev-handler

Conversation

@tejaskash

@tejaskash tejaskash commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • implement agentcore project dev runtime selection, port resolution, runner dispatch, structured output, and signal handling
  • reuse withProject for project discovery and actionable missing-project guidance
  • load runtime and .env.local values directly; containers forward host AWS variables, mount ~/.aws read-only, and fail early when neither credential source exists
  • reuse shared JSON rendering for NDJSON events and generalize command interruption handling

Stacks on #1962.

Verification

  • bun test (1107 pass)
  • bun run typecheck
  • bun run lint:check
  • bun run format:check
  • bun run build
  • executable smoke: scaffolded a real Python project, ran project dev, received healthy /ping, interrupted with exit 130, and verified child cleanup and port release
  • executable no-project probe verified the actionable project create guidance

@github-actions github-actions Bot added the size/xl PR size: XL label Aug 10, 2026
@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Aug 10, 2026
@tejaskash
tejaskash force-pushed the feat/project-dev-handler branch from 736c095 to 3d6dd24 Compare August 10, 2026 20:57
@codecov-commenter

codecov-commenter commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.00990% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.06%. Comparing base (2dba459) to head (f0b65c9).

Files with missing lines Patch % Lines
src/core/dev/path.ts 92.59% 2 Missing ⚠️
src/handlers/project/dev/environment.ts 97.14% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           refactor    #1966      +/-   ##
============================================
+ Coverage     97.04%   97.06%   +0.02%     
============================================
  Files           370      374       +4     
  Lines         22287    22542     +255     
============================================
+ Hits          21628    21880     +252     
- Misses          659      662       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tejaskash
tejaskash force-pushed the feat/project-dev-handler branch from 3d6dd24 to d003ce7 Compare August 10, 2026 21:25
@jariy17
jariy17 force-pushed the feat/project-dev-handler branch from d003ce7 to 3b72b9c Compare August 10, 2026 22:55
@tejaskash
tejaskash force-pushed the feat/project-dev-handler branch from 3b72b9c to 03f5223 Compare August 11, 2026 01:12
@tejaskash
tejaskash force-pushed the feat/project-dev-handler branch from 03f5223 to b7c2b24 Compare August 11, 2026 14:05
@tejaskash
tejaskash force-pushed the feat/project-dev-handler branch 3 times, most recently from ac10a56 to 17d2047 Compare August 12, 2026 13:10
@tejaskash
tejaskash force-pushed the feat/project-dev-handler branch 2 times, most recently from 126d77b to c55046e Compare August 12, 2026 13:42
@tejaskash
tejaskash force-pushed the feat/project-dev-handler branch from c55046e to 37312c9 Compare August 13, 2026 14:02
Base automatically changed from feat/container-dev-runner to refactor August 13, 2026 17:37
@tejaskash
tejaskash force-pushed the feat/project-dev-handler branch from 37312c9 to 73ab887 Compare August 13, 2026 17:41

@Hweinstock Hweinstock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only blocking comment is the direct process kill.

Comment thread src/core/dev/container.test.ts
Comment thread src/core/dev/container.ts Outdated
Comment thread src/core/dev/container.ts Outdated
Comment thread src/core/dev/port.ts Outdated
Comment thread src/errors/errors.tsx
Comment thread src/handlers/project/dev/index.ts Outdated
Comment thread src/handlers/project/dev/index.ts
Comment thread src/handlers/project/index.ts Outdated
Comment thread package.json
@tejaskash
tejaskash force-pushed the feat/project-dev-handler branch from 73ab887 to 32e0283 Compare August 14, 2026 15:06
@tejaskash
tejaskash requested a review from Hweinstock August 14, 2026 15:07
@tejaskash
tejaskash force-pushed the feat/project-dev-handler branch 2 times, most recently from 74c4f1d to e6c8aa1 Compare August 14, 2026 15:19
Comment thread src/handlers/project/dev/index.ts
Comment thread src/handlers/project/dev/environment.ts
@tejaskash
tejaskash force-pushed the feat/project-dev-handler branch from e6c8aa1 to 85d6498 Compare August 14, 2026 16:01
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
Comment thread src/core/dev/container.ts
Comment thread src/core/dev/container.ts
Hweinstock
Hweinstock previously approved these changes Aug 14, 2026
@tejaskash
tejaskash force-pushed the feat/project-dev-handler branch from 90abf1f to 6118781 Compare August 17, 2026 17:46
Hweinstock
Hweinstock previously approved these changes Aug 17, 2026
Comment thread src/handlers/runtime/invoke/index.tsx Outdated
Comment thread src/core/dev/container.ts Outdated
Comment thread src/handlers/project/index.ts

@aidandaly24 aidandaly24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I will replace the user cancellation error with mine in #1986

@aidandaly24
aidandaly24 merged commit a317a83 into refactor Aug 17, 2026
15 checks passed
@aidandaly24
aidandaly24 deleted the feat/project-dev-handler branch August 17, 2026 20:46
@aidandaly24

Copy link
Copy Markdown
Contributor

Saw that Harrison had also approved earlier so merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xl PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants