refactor(tel): rename end to emit

Author: Hweinstock

src/index.ts

@@ -93,7 +93,7 @@ process.exit(
       throw error;
     } finally {
       try {
-        await commandRunMetricEvent.end(Date.now() - startTime);
+        await commandRunMetricEvent.emit(Date.now() - startTime);
       } catch (e) {
         const error = AgentCoreCLIError.fromError(e);
         rootLogger.child({ error: error.json() }).warn("failed to emit telemetry");

src/router/router.test.ts

@@ -721,7 +721,7 @@ test.each([
     commandRunMetricEvent.setAttributes({ exit_reason: "success" });
   }
 
-  await commandRunMetricEvent.end(100);
+  await commandRunMetricEvent.emit(100);
 
   expect(recordedMetrics).toHaveLength(1);
   expect(recordedMetrics[0]!.metricName).toBe("cli.command_run");

src/telemetry/client.test.tsx

@@ -45,15 +45,15 @@ describe("DefaultTelemetryClient", () => {
       command_path: "/agentcore",
     });
 
-    await metricEvent.end(123);
+    await metricEvent.emit(123);
 
     // Start a second event with failure
     const metricEvent2 = client.startMetricEvent("cli.command_run", {
       exit_reason: "failure",
       command_path: "/agentcore",
     });
 
-    await metricEvent2.end(456);
+    await metricEvent2.emit(456);
     await client.shutdown();
 
     expect(fileSystemSink.getName()).toBe("FileSystemSink");
@@ -139,14 +139,14 @@ describe("DefaultTelemetryClient", () => {
       command_path: "/agentcore",
       is_tui: true,
     });
-    await enabledEvent.end(123);
+    await enabledEvent.emit(123);
 
     const disabledEvent = disabledClient.startMetricEvent("cli.command_run", {
       exit_reason: "failure",
       command_path: "/agentcore",
       is_tui: false,
     });
-    await disabledEvent.end(123);
+    await disabledEvent.emit(123);
 
     await Promise.all([enabledClient.shutdown(), disabledClient.shutdown()]);
 
@@ -181,7 +181,7 @@ describe("DefaultTelemetryClient", () => {
 
     const metricEvent = client.startMetricEvent("cli.command_run");
 
-    await expect(metricEvent.end(100)).rejects.toThrow();
+    await expect(metricEvent.emit(100)).rejects.toThrow();
     await client.shutdown();
   });
 
@@ -202,7 +202,7 @@ describe("DefaultTelemetryClient", () => {
       exit_reason: "success",
       command_path: "/agentcore",
     });
-    await metricEvent.end(1);
+    await metricEvent.emit(1);
     await client.shutdown();
 
     await assertLogsMatch(tempDir, [
@@ -248,7 +248,7 @@ describe("DefaultTelemetryClient", () => {
     });
 
     // end should not throw even though the sink's send() throws
-    await metricEvent.end(100);
+    await metricEvent.emit(100);
     // shutdown should not throw even though the sink's shutdown() rejects
     await client.shutdown();
 

src/telemetry/client.tsx

@@ -140,7 +140,7 @@ class InMemoryMetricEvent<TMetricName extends MetricName> implements MetricEvent
     };
   }
 
-  async end(value: ValueOf<TMetricName>): Promise<void> {
+  async emit(value: ValueOf<TMetricName>): Promise<void> {
     const metricAttributes = METRICS[this.metricName]["attributeSchema"].parse(this.data);
     const validatedValue = METRICS[this.metricName]["valueSchema"].parse(value);
     const resourceAttributes = await this.getResourceAttributes();

src/telemetry/types.tsx

@@ -24,8 +24,8 @@ export interface MetricEvent<TMetricName extends MetricName> {
   /** Accumulate attributes incrementally. Later calls overwrite earlier values for the same key. */
   setAttributes(data: Partial<AttributesOf<TMetricName>>): void;
 
-  /** Validate attributes, emit value + attributes to all sinks. */
-  end(value: ValueOf<TMetricName>): Promise<void>;
+  /** Validate attributes and emit value + attributes to all sinks. */
+  emit(value: ValueOf<TMetricName>): Promise<void>;
 }
 
 /**