Commit eb4ea4f
committed
fix(exec): derive region from the ARN so --runtime needs no project
`agentcore exec --runtime <arn>` failed with "AWS Targets config file not
found" unless --region was also passed. The ARN short-circuit in
loadExecContext was gated on `startsWith('arn:') && options.region`, so
omitting --region fell through to readAWSDeploymentTargets() /
readDeployedState(), which throw before anything else runs.
The fall-through branch already existed and was labelled "--runtime <arn>
with no --region", but it sat after those reads and used config for one
thing: `options.region ?? targetConfig.region`. That region is field 3 of
the ARN the caller just supplied, so exec was demanding a project, an
aws-targets.json and a completed deploy to recover a value it already had.
This blocks exec for anyone deploying runtimes outside the CLI (CDK,
pipelines, personal stacks), who have no reason to own an agentcore
project at all.
Parse the region from the ARN instead and drop the --region requirement
from both the --runtime and --harness short-circuits. Config is now read
only when a *name* needs resolving, or when the ARN's region field is
empty or malformed. An explicit --region still wins.
regionFromArn moves from operations/jobs/shared/region to a new cli/aws/arn
module so exec does not have to depend on operations/jobs; the jobs path
re-exports it. It lives apart from cli/aws/region because that module
detects the ambient region via env and shared config files, while this is a
pure function over an ARN the caller already holds -- and several jobs tests
replace cli/aws/region wholesale with a detectRegion-only factory mock.1 parent e23bb22 commit eb4ea4f
4 files changed
Lines changed: 103 additions & 24 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
767 | 767 | | |
768 | 768 | | |
769 | 769 | | |
770 | | - | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
771 | 793 | | |
772 | | - | |
| 794 | + | |
773 | 795 | | |
774 | 796 | | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
775 | 817 | | |
776 | | - | |
| 818 | + | |
777 | 819 | | |
778 | 820 | | |
779 | 821 | | |
| |||
858 | 900 | | |
859 | 901 | | |
860 | 902 | | |
861 | | - | |
862 | | - | |
863 | | - | |
864 | | - | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
| 909 | + | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
865 | 919 | | |
866 | 920 | | |
867 | 921 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
| 42 | + | |
41 | 43 | | |
42 | 44 | | |
43 | 45 | | |
| |||
46 | 48 | | |
47 | 49 | | |
48 | 50 | | |
49 | | - | |
50 | | - | |
51 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
52 | 61 | | |
53 | 62 | | |
54 | | - | |
55 | | - | |
| 63 | + | |
| 64 | + | |
56 | 65 | | |
57 | 66 | | |
58 | 67 | | |
59 | 68 | | |
60 | 69 | | |
61 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
62 | 74 | | |
63 | 75 | | |
64 | 76 | | |
| |||
85 | 97 | | |
86 | 98 | | |
87 | 99 | | |
88 | | - | |
| 100 | + | |
| 101 | + | |
89 | 102 | | |
90 | 103 | | |
91 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
8 | 13 | | |
9 | 14 | | |
10 | 15 | | |
| |||
24 | 29 | | |
25 | 30 | | |
26 | 31 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
0 commit comments