refactor(project): swap to class based implementation

Author: Hweinstock

src/core/index.tsx

@@ -12,7 +12,7 @@ import type {
 } from "./types";
 import type { Logger } from "../logging";
 import type { ProjectManager } from "../handlers/project/types";
-import { createProjectManager } from "./project";
+import { FsProjectManager } from "./project";
 
 export type {
   AwsClients,
@@ -55,7 +55,7 @@ export class CoreClient implements AwsClients {
     this.createIamClient = config.createIamClient;
     this.logger = config.logger;
 
-    this.projectManager = createProjectManager({
+    this.projectManager = new FsProjectManager({
       logger: this.logger.child({ module: "projectManager" }),
     });
   }

src/core/project/index.tsx

@@ -1 +1 @@
-export { createProjectManager } from "./manager";
+export { FsProjectManager } from "./manager";

src/core/project/manager.tsx

@@ -1,20 +1,26 @@
-import type { ProjectManager } from "../../handlers/project/types";
+import type {
+  CreateProjectInput,
+  FindProjectInput,
+  Project,
+  ProjectManager,
+} from "../../handlers/project/types";
 import type { Logger } from "../../logging";
 
-type CreateProjectManagerConfig = {
+type ProjectManagerConfig = {
   logger: Logger;
 };
 
 /**
- * Creates a {@link ProjectManager} that relies on the local file system to manage access to projects.
+ * An implementation of {@link ProjectManager} that relies on the local file system to manage access to projects.
  */
-export function createProjectManager(_config: CreateProjectManagerConfig): ProjectManager {
-  return {
-    find: (_input) => {
-      throw new Error(`ProjectManager.find is not implemented yet`);
-    },
-    create: (_input) => {
-      throw new Error(`ProjectManager.create is not implemented yet`);
-    },
-  };
+export class FsProjectManager implements ProjectManager {
+  constructor(_config: ProjectManagerConfig) {}
+
+  public find(_input: FindProjectInput): Promise<Project> {
+    throw new Error(`ProjectManager.find is not implemented yet`);
+  }
+
+  public create(_input: CreateProjectInput): Promise<Project> {
+    throw new Error(`ProjectManager.create is not implemented yet`);
+  }
 }

src/handlers/runtime/runtime.test.tsx

@@ -16,7 +16,7 @@ const MISSING_RUNTIME_ID = "missing_runtime-0000000000";
 
 function createFixtureCore(): CoreClient {
   const { createControlClient, createDataClient, createIamClient } = fixtureFactories(FIXTURES);
-  return new CoreClient(createControlClient, createDataClient, createIamClient);
+  return new CoreClient({ createControlClient, createDataClient, createIamClient, logger: createSilentLogger() });
 }
 
 async function run(args: string[]): Promise<string> {

src/middleware/withProject.test.ts

@@ -1,12 +1,12 @@
 import { test, expect, describe } from "bun:test";
 import { Router, createHandler } from "../router";
-import { createProjectManager } from "../core/project";
 import { createSilentLogger } from "../testing";
 import { withProject } from "./withProject";
+import { FsProjectManager } from "../core/project";
 
 describe("withProject", () => {
   test("throws not implemented", async () => {
-    const projectManager = createProjectManager({ logger: createSilentLogger() });
+    const projectManager = new FsProjectManager({ logger: createSilentLogger() });
 
     const app = new Router("app", "test");
     app.use(withProject({ projectManager, cwd: "/some/path" }));

src/testing/TestCoreClient.tsx

@@ -36,7 +36,7 @@ import type { CoreOptions } from "../core/types";
 import type { ProjectManager } from "../handlers/project/types";
 import type { Logger } from "../logging";
 import { createSilentLogger } from "./logging";
-import { createProjectManager } from "../core/project";
+import { FsProjectManager } from "../core/project";
 
 // TestCoreClient is a hand-controllable `Core` for tests. It implements the same
 // interface the real CoreClient satisfies, so it drops straight into
@@ -481,6 +481,6 @@ export class TestCoreClient implements Core {
   readonly projectManager: ProjectManager;
 
   constructor(options?: TestCoreClientOptions) {
-    this.projectManager = createProjectManager({ logger: options?.logger ?? createSilentLogger() });
+    this.projectManager = new FsProjectManager({ logger: options?.logger ?? createSilentLogger() });
   }
 }