Skip to content

Commit 346e476

Browse files
committed
fix(memory): defer default view resolution
1 parent 61d34c0 commit 346e476

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

src/handlers/memory/get/index.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export const createGetMemoryHandler = (core: Core) =>
1212
description: "get an AgentCore Memory",
1313
flags: [
1414
flag("id", "the ID of the Memory", z.string().optional()),
15-
flag("view", "response view", z.enum(MEMORY_VIEWS).default("full")),
15+
flag("view", "response view", z.enum(MEMORY_VIEWS).optional()),
1616
],
1717
handle: async (ctx, flags) => {
1818
if (!flags.id) {
@@ -21,6 +21,8 @@ export const createGetMemoryHandler = (core: Core) =>
2121

2222
ctx
2323
.require(JsonRendererKey)
24-
.renderJson(await core.memory.getMemory(flags.id, flags.view, coreOptsFromCtx(ctx)));
24+
.renderJson(
25+
await core.memory.getMemory(flags.id, flags.view ?? "full", coreOptsFromCtx(ctx)),
26+
);
2527
},
2628
});

src/handlers/memory/memory.test.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import {
99
testIO,
1010
} from "../../testing";
1111
import { createRootHandler } from "../index";
12+
import { createGetMemoryHandler } from "./get";
1213

1314
const REGION = "us-west-2";
1415
const FIXTURES = join(import.meta.dir, "__fixtures__");
@@ -54,6 +55,13 @@ describe("memory command hierarchy", () => {
5455
expect(memory?.children().map((child) => child.name())).toEqual(["get", "list"]);
5556
});
5657

58+
test("keeps an omitted get view undefined for empty-flag routing", () => {
59+
const get = createGetMemoryHandler(createFixtureCore());
60+
const view = get.flags().find((flag) => flag.name === "view");
61+
62+
expect(view?.schema.parse(undefined)).toBeUndefined();
63+
});
64+
5765
test("prints help for bare `memory` without an SDK call", async () => {
5866
const stdout = await run(["memory"]);
5967

0 commit comments

Comments
 (0)