Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main readme does not mention NGC_CLI_API_KEY #43

Open
wood-brandon opened this issue Mar 6, 2025 · 0 comments
Open

Main readme does not mention NGC_CLI_API_KEY #43

wood-brandon opened this issue Mar 6, 2025 · 0 comments

Comments

@wood-brandon
Copy link

Deploying this solution with a Nvidia based setup leads to three modules failing to build due to absence of the NGC_CLI_API_KEY key in the passed secret:

[Container]  Running command if [ -n "${NGC_CLI_API_KEY+x}" ]; then echo $NGC_CLI_API_KEY | docker login --username '$oauthtoken' --password-stdin nvcr.io; else echo "NGC_CLI_API_KEY is unset"; if [[ $NAME == *-nim ]]; then echo "NGC_CLI_API_KEY required to build NIM containers, exiting"; JSON_DATA=$( jq -n --arg uid "$NAME" '{Status:"SUCCESS", Reason:"Configuration Complete","UniqueId":$uid, "Data":"Application has completed configuration."}' ); curl -X PUT -H "Content-Type:" --data-binary "$JSON_DATA" "$WAIT_CONDITION_HANDLE"; fi fi
NGC_CLI_API_KEY is unset
NGC_CLI_API_KEY required to build NIM containers, exiting

This key value pair NGC_CLI_API_KEY is not mentioned in the main README.md in favor of API_KEY and ORG, but is instead buried in the asset workflows README e.g. alphabind

This would require a duplication of information for the final secret, e.g.:

`API_KEY`: mynvidiaapikey
`ORG`: mynvidiaorg
`NGC_CLI_API_KEY`: mynvidiaapikey
` `: mynvidiaorg

For ease of use, could we either:

  • (preferably) modify the keys NGC_CLI_API_KEY NGC_CLI_ORG to instead point at API_KEY / ORG
  • Adjust the main README to mention these extra keys as part of the quick start guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant