Skip to content

Commit 020be14

Browse files
committed
Correct missing factor of pi in Z and alpha
This was confirmed against the spreadsheet Z and Z*alpha values from Ahren's 2020 paper.
1 parent 4361643 commit 020be14

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/automol/etrans/_fxn.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@ def troe_lj_collision_frequency(eps, sig, red_mass, temp):
1111
""" Collision Frequency formula from Troe that uses
1212
Lennard-Jones epsilons and sigma parameters
1313
14-
Z = sqrt( (8*kB*T)/(pi*mu) ) * sig^2 * omega
14+
Z = pi * sqrt( (8*kB*T)/(pi*mu) ) * sig^2 * omega
1515
omega = [ 0.7 + 0.5 log10( (kB*T)/eps ) ]^-1
1616
17+
See Eq. 12 from Jasper, J. Phys. Chem. A 2009, 113, 19, 5612-5619
18+
1719
:param eps: Target+Bath Lennard-Jones epsilon value (in hart)
1820
:type eps: float
1921
:param sig: Target+Bath Lennard-Jones sigma value (in bohr)
@@ -35,7 +37,7 @@ def troe_lj_collision_frequency(eps, sig, red_mass, temp):
3537
kbt = phycon.KB * temp
3638

3739
# Prefactor term with physical constants and masses
38-
pref1 = numpy.sqrt((8.0 * kbt) / (numpy.pi * red_mass))
40+
pref1 = numpy.pi * numpy.sqrt((8.0 * kbt) / (numpy.pi * red_mass))
3941

4042
# Omega integral
4143
omega_s = (0.7 + 0.52 * (numpy.log10(kbt / eps)))**(-1)

src/automol/tests/test_etrans.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def test__estimate():
167167
# Build the alpha parameters
168168
edown_alpha, edown_n = automol.etrans.estimate.alpha(
169169
n_eff, eps, sig, tgt_mass, bath_mass, collider_set)
170-
ref_edown_alpha = 457.24552400133837
170+
ref_edown_alpha = 457.24552400133837 / numpy.pi
171171
ref_edown_n = 0.70088400006973
172172
assert numpy.isclose(edown_alpha, ref_edown_alpha)
173173
assert numpy.isclose(edown_n, ref_edown_n)

0 commit comments

Comments
 (0)