#47 - Remove use of Java8 @generated and instead just use javax.annotation.processing.Generated if java9+

rbygrave · rbygrave · commit d5e982140b99 · 2020-08-27T00:14:15.000+12:00
diff --git a/dinject-generator/src/main/java/io/dinject/generator/Constants.java b/dinject-generator/src/main/java/io/dinject/generator/Constants.java
@@ -4,7 +4,6 @@ class Constants {
 
   static final String KOTLIN_METADATA = "kotlin.Metadata";
   static final String GENERATED_9 = "javax.annotation.processing.Generated";
-  static final String GENERATED_8 = "javax.annotation.Generated";
 
   static final String POSTCONSTRUCT = "javax.annotation.PostConstruct";
   static final String PROVIDER = "javax.inject.Provider";
diff --git a/dinject-generator/src/main/java/io/dinject/generator/ProcessingContext.java b/dinject-generator/src/main/java/io/dinject/generator/ProcessingContext.java
@@ -53,10 +53,7 @@ class ProcessingContext {
   }
 
   private String generatedAnnotation(boolean jdk8) {
-    if (jdk8) {
-      return isTypeAvailable(Constants.GENERATED_8) ? Constants.GENERATED_8 : null;
-    }
-    return isTypeAvailable(Constants.GENERATED_9) ? Constants.GENERATED_9 : null;
+    return jdk8 ? null : isTypeAvailable(Constants.GENERATED_9) ? Constants.GENERATED_9 : null;
   }
 
   private boolean isTypeAvailable(String canonicalName) {

Original file line number	Diff line number	Diff line change
`@@ -53,10 +53,7 @@ class ProcessingContext {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`private String generatedAnnotation(boolean jdk8) {`
`56`		`- if (jdk8) {`
`57`		`- return isTypeAvailable(Constants.GENERATED_8) ? Constants.GENERATED_8 : null;`
`58`		`- }`
`59`		`- return isTypeAvailable(Constants.GENERATED_9) ? Constants.GENERATED_9 : null;`
	`56`	`+ return jdk8 ? null : isTypeAvailable(Constants.GENERATED_9) ? Constants.GENERATED_9 : null;`
`60`	`57`	`}`
`61`	`58`
`62`	`59`	`private boolean isTypeAvailable(String canonicalName) {`