feat: port autoware_motion_utils from autoware.universe #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jack.song <[email protected]>
Signed-off-by: jack.song <[email protected]>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
youtalk
added
the
run:build-and-test-differential
youtalk
reviewed
Jan 8, 2025
Signed-off-by: NorahXiong <[email protected]>
Co-authored-by: Yutaka Kondo <[email protected]> Signed-off-by: NorahXiong <[email protected]>
NorahXiong
force-pushed
the
autocore_motion
branch
from
3b7b83b to
157be56
Compare
youtalk
requested changes
Jan 15, 2025
| <depend>autoware_adapi_v1_msgs</depend> | ||
| <depend>autoware_interpolation</depend> | ||
| <depend>autoware_planning_msgs</depend> | ||
| <depend>autoware_universe_utils</depend> |
There was a problem hiding this comment.
We need to eliminate the dependency on the autoware_universe_utils. Let’s migrate only the necessary files to autoware.core. cc @mitsudome-r
There was a problem hiding this comment.
Someone is working on the problem by splitting the package into two parts. I will fix the building error once the autoware_universe_utils package is ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links
#139
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.