-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead-code #2157
base: main
Are you sure you want to change the base?
Remove dead-code #2157
Conversation
… SubjectByTypeSet.Len
…bugAnalyzeBeforeStatistics
…ebugAnalyzeBeforeStatistics
…unc: tracingLogger.Log
…AnalyzeBeforeStatistic
…: WithQueryInterceptor
…unc: ConnectWithInstrumentation
…: RemoteDispatchTimeout
…oundError.NamespaceName
…oundError.NotFoundRelationNa
…or.MarshalZerologObject
…oundError.DetailsMetadata
…tFoundErr internal/graph/errors.go:136:6: unreachable func: NewRelationMissingTypeInfoErr
…ternal/logging/logger.go:47:6: unreachable func: Printf
… func: FromContext and internal/middleware/dispatcher/dispatcher.go:38:6: unreachable func: MustFromContext
…c: WithUnaryServiceSpecificInterceptor.UnaryInterceptor
…sterDeveloperServer
…43: cannot use RelationNotFoundError{} (value of type RelationNotFoundError) as sharederrors.UnknownRelationError value in variable declaration: RelationNotFoundError does not implement sharederrors.UnknownRelationError (missing method NamespaceName)
…43: cannot use RelationNotFoundError{} (value of type RelationNotFoundError) as sharederrors.UnknownRelationError value in variable declaration: RelationNotFoundError does not implement sharederrors.UnknownRelationError (missing method NotFoundRelationName)
…erceptor.go:44:45: cannot use WithUnaryServiceSpecificInterceptor{} (value of type WithUnaryServiceSpecificInterceptor) as servicespecific.ExtraUnaryInterceptor value in variable declaration: WithUnaryServiceSpecificInterceptor does not implement servicespecific.ExtraUnaryInterceptor (missing method UnaryInterceptor)
…spatcher.go:13:22: undefined: dispatchermw.FromContext
…:31:25: undefined: shared.AsValidationError
…reachable func: TrackingSubjectSet.RemoveFrom
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 0 out of 2 committers have signed the CLA. |
Hey Ivan, appreciate the PR, but we can't blindly accept this. Many of these functions are exported, which means that Go code importing SpiceDB would break. I'd suggest removing only unexported code to begin with. |
Addresses the most of dead-code from #1719
➜ spicedb git:(main) deadcode -test ./... | grep -v pkg
➜ spicedb git:(ivan-remove-dead-code-1719) deadcode -test ./... | grep -v pkg