Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete performance improvements #1771

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Delete performance improvements #1771

merged 3 commits into from
Mar 1, 2024

Conversation

josephschorr
Copy link
Member

@josephschorr josephschorr commented Feb 29, 2024 •
edited
Loading

Improve deletion performance:

  1. Have CRDB datastore use a combined query instead of individual queries
  2. Switch limit-ed deletes to use inline DELETE ... LIMIT where applicable

@josephschorr josephschorr force-pushed the delete-perf-improvements branch from b94181e to 05f48fb Compare February 29, 2024 20:22
@github-actions github-actions bot added area/api v1 Affects the v1 API area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Feb 29, 2024
@josephschorr josephschorr force-pushed the delete-perf-improvements branch from 05f48fb to 3e0766f Compare February 29, 2024 20:27
@josephschorr josephschorr force-pushed the delete-perf-improvements branch from 3e0766f to ed90d46 Compare February 29, 2024 20:33
@josephschorr josephschorr marked this pull request as ready for review February 29, 2024 20:40
@josephschorr josephschorr requested a review from a team February 29, 2024 20:40
@josephschorr josephschorr added this pull request to the merge queue Mar 1, 2024
Merged via the queue into authzed:main with commit 0383c7e Mar 1, 2024
20 checks passed
@josephschorr josephschorr deleted the delete-perf-improvements branch March 1, 2024 23:15
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ecordell ecordell ecordell approved these changes

@vroldanbet vroldanbet Awaiting requested review from vroldanbet vroldanbet is a code owner

Assignees
No one assigned
Labels
area/api v1 Affects the v1 API area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephschorr @ecordell