Last round of lint fixes #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tstirrat15
commented
Jan 23, 2025
Comment on lines
-16
to
-20
| /** | ||
| * withRouter, it specified, is the router to wrap the application with. | ||
| */ | ||
| withRouter?: any; | ||
|
|
There was a problem hiding this comment.
I looked at index.tsx and realized that this only ever has one value, so I got rid of the prop passing as unnecessary complexity.
| return ( | ||
| <Router> |
There was a problem hiding this comment.
This got lifted up, which means we could get rid of the props and this wrapping.
| @@ -713,8 +702,10 @@ export function ThemedAppView(props: { datastore: DataStore }) { | |||
| return; | |||
| } | |||
|
|
|||
| cookieService.setRelationshipsEditorType(type); | |||
| setRelationshipEditor(type); | |||
| if (type === 'grid' || type === 'code') { | |||
| @@ -118,7 +118,7 @@ function InlinePlaygroundUI(props: { datastore: DataStore }) { | |||
| ); | |||
|
|
|||
| const handleChangeTab = ( | |||
| event: React.ChangeEvent<{}>, | |||
| _event: React.ChangeEvent<object>, | |||
There was a problem hiding this comment.
MUI's types here are kinda jank. This satisfies the type without using {}, since we can't use HTMLElement here.
| @@ -165,6 +165,7 @@ export function usePanelsCoordinator<L extends string>(props: PanelCoordinatorPr | |||
| } | |||
| } catch (e) { | |||
| // Do nothing. | |||
| console.error(e) | |||
There was a problem hiding this comment.
Sending it to the console in case someone wants to look, which also silences an unused var lint error.
alecmerdler
approved these changes
Jan 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the last of the lint fixes.
Changes
Testing
Review. See that things pass.