Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Insecure Client for Convenience #193

Merged
merged 20 commits into from
Sep 4, 2024
Merged

Conversation

tstirrat15
Copy link
Contributor

Fixes #89

Description

One thing that most users of our library run into is that you can't use client credentials in a non-TLS context with the way that the Python gRPC lib is designed. This was likely intentional; network sniffing can turn into credential exposure in a production environment. However, it's frustrating and inconvenient when all you want to do is try out the lib using docker-compose.

This provides an InsecureClient that implements a workaround for those contexts.

Changes

  • Add grpc-interceptor as a dep for setting up the new interceptor
  • Reorganize some code to make things more reusable
  • Add an InsecureClient to allow for the use case

Testing

Review. See that tests pass and that you can set up a connection with the InsecureClient.

@tstirrat15 tstirrat15 requested a review from a team September 3, 2024 21:25
@tstirrat15 tstirrat15 changed the title 89 manual credential setup Add Insecure Client for Convenience Sep 3, 2024
tests/insecure_client_test.py Show resolved Hide resolved
tests/insecure_client_test.py Show resolved Hide resolved
@tstirrat15 tstirrat15 force-pushed the 89-manual-credential-setup branch from 5a5f2ea to e667577 Compare September 4, 2024 14:44
@tstirrat15 tstirrat15 added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit a453cdf Sep 4, 2024
15 checks passed
@tstirrat15 tstirrat15 deleted the 89-manual-credential-setup branch September 4, 2024 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to connect to all addresses; Endpoint is neither UDS or TCP loopback address
2 participants