Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations directly to clients #208

Closed
wants to merge 1 commit into from

Conversation

tstirrat15
Copy link
Contributor

Fixes #207

Description

This has been a pain point a couple of times now - I make some modification to the client files and forget to make associated updates to the stub files. I figure that adding the type annotations directly to the client file should satisfy mypy and prevent me from making that mistake again.

This should be generally fine, since our targeted python versions are compatible with type annotations.

Changes

  • Add type annotations to the clients directly

Testing

Review.

@tstirrat15 tstirrat15 requested a review from a team September 20, 2024 16:18
@tstirrat15
Copy link
Contributor Author

Hmm... This won't work because 3.8 and 3.9 don't support unioning abstract base classes. Oh well.

@tstirrat15 tstirrat15 closed this Sep 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make types in __init__.py and __init__.pyi agree
1 participant