Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signinPopup in AuthContextProps should return Promise<User | null> #1452

Open
benh-dug opened this issue Jan 9, 2025 · 0 comments
Open

signinPopup in AuthContextProps should return Promise<User | null> #1452

benh-dug opened this issue Jan 9, 2025 · 0 comments

Comments

@benh-dug
Copy link

benh-dug commented Jan 9, 2025

As a follow-up to #820 (comment) I believe that the 'signinPopup' function should return a possibly null value.

I ran into a similar issue to the linked comment where the promise actually resolved to null (When I closed the popup) and I didn't have any typing warning me that could happen.

I'd be happy to raise a PR if this is expected behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant