Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point from HTTP-Client docs to DI #477

Open
Ryuno-Ki opened this issue Apr 5, 2020 · 0 comments
Open

Point from HTTP-Client docs to DI #477

Ryuno-Ki opened this issue Apr 5, 2020 · 0 comments

Comments

@Ryuno-Ki
Copy link

Ryuno-Ki commented Apr 5, 2020

This issue was originally opened in aurelia/site-generator#30. I've updated the reference here.

Hey there!

I'm currently porting a small demo over to Aurelia from Angular 9 and love it so far!
I'm not sure, whether this repo is still used for updating the website, but …

What is the motivation / use case for changing the behavior?
In HTTP Services you are currently describing, how to build AJAX requests.

You also recommend (typo in the docs!) to:

Instead, we reccommend that you create one or more service classes that encapsulate all HTTP access behind a friendly, application-specific API.

I'd suggest to place a link there to Dependency Injection, because that would describe how the service class would be written.

I discovered the page via a DDG-Search finally.

Thanks for making Aurelia :-)
The project evolved way better (watching your progress since the Skeleton times ;-) )

Ryuno-Ki added a commit to Ryuno-Ki/documentation that referenced this issue Apr 7, 2020
It doesn't fit optimal, but when I first read the docs regarding HttpClient, I wondered _how_ to wrap the client in a custom service.
This way, there's at least a starting point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant