Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(testing/components): Clarify Testing a Custom Element #442

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

doc(testing/components): Clarify Testing a Custom Element #442

wants to merge 2 commits into from

Conversation

baerrach
Copy link
Contributor

Removed inform box specific to Karma as there is no documentation at all about
how to set Karma up.

Fixes #441

@baerrach
doc(testing/components): Clarify Testing a Custom Element
2d53a5d 
Removed inform box specific to Karma as there is no documentation at all about
how to set Karma up.

Fixes aurelia#441
@baerrach
doc(testing/components): Custom Attribute remove src/ prefix from .wi…
5ca0b0f 
…thResources

Fixes aurelia#441
@EisenbergEffect
Copy link
Contributor

Was this the final outcome of the conversation or were we waiting on @3cp to respond to #441 ?

@zewa666
Copy link
Member

zewa666 commented Jul 16, 2019

@EisenbergEffect I'd like @3cp to chime into this discussion as he has a better overview of how Karma, Jest and other fit into the CLI.

@3cp
Copy link
Member

3cp commented Jul 16, 2019

With cli, it definitely has no need of src/ prefix, for all karma/jest/cli-bundler/webpack. The doc is outdated I guess.

But with webpack+karma, you do need .withResources(PLATFORM.moduleName('some-comp')) wrapper for webpack to trace it.

The jest has config inside app package.json to skip the src/ prefix.

"modulePaths": [
      "<rootDir>/src",
      "<rootDir>/node_modules"
    ],

@3cp 3cp mentioned this pull request Jul 16, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing Components is out of sync with latest Aurelia
4 participants
@baerrach @EisenbergEffect @zewa666 @3cp